From 9b09e74fdfd397bb3cbe2cb7f5270c58d108739d Mon Sep 17 00:00:00 2001
From: Cold Fry <coldfry.business@gmail.com>
Date: Thu, 26 Mar 2026 23:13:30 +0000
Subject: [PATCH] fix Number.MAX_SAFE_INTEGER, MIN_SAFE_INTEGER, MIN_VALUE,
 MAX_VALUE emitting wrong Lua

All four constants evaluated to Infinity or -Infinity in Lua. Additionally,
MIN_SAFE_INTEGER and MIN_VALUE emitted identical code, as did MAX_SAFE_INTEGER
and MAX_VALUE. The existing test did not catch this because it only checked
Lua-side results with comparisons that the wrong values accidentally satisfied.
---
 src/transformation/builtins/number.ts | 55 +++++++++++++++++++++------
 test/unit/builtins/numbers.spec.ts    | 24 +++++++-----
 2 files changed, 58 insertions(+), 21 deletions(-)

diff --git a/src/transformation/builtins/number.ts b/src/transformation/builtins/number.ts
index 17c44b6fd..ecb98da64 100644
--- a/src/transformation/builtins/number.ts
+++ b/src/transformation/builtins/number.ts
@@ -77,31 +77,62 @@ export function transformNumberProperty(
                 node
             );
         case "MIN_VALUE":
+            // 2 ^ -1074 = 5e-324 (smallest positive double)
             return lua.createBinaryExpression(
-                lua.createNumericLiteral(-2),
-                lua.createNumericLiteral(1074),
+                lua.createNumericLiteral(2),
+                lua.createNumericLiteral(-1074),
                 lua.SyntaxKind.PowerOperator,
                 node
             );
         case "MIN_SAFE_INTEGER":
-            return lua.createBinaryExpression(
-                lua.createNumericLiteral(-2),
-                lua.createNumericLiteral(1074),
-                lua.SyntaxKind.PowerOperator,
+            // -(2 ^ 53 - 1) = -9007199254740991
+            return lua.createUnaryExpression(
+                lua.createParenthesizedExpression(
+                    lua.createBinaryExpression(
+                        lua.createBinaryExpression(
+                            lua.createNumericLiteral(2),
+                            lua.createNumericLiteral(53),
+                            lua.SyntaxKind.PowerOperator
+                        ),
+                        lua.createNumericLiteral(1),
+                        lua.SyntaxKind.SubtractionOperator
+                    )
+                ),
+                lua.SyntaxKind.NegationOperator,
                 node
             );
         case "MAX_SAFE_INTEGER":
+            // 2 ^ 53 - 1 = 9007199254740991
             return lua.createBinaryExpression(
-                lua.createNumericLiteral(2),
-                lua.createNumericLiteral(1024),
-                lua.SyntaxKind.PowerOperator,
+                lua.createBinaryExpression(
+                    lua.createNumericLiteral(2),
+                    lua.createNumericLiteral(53),
+                    lua.SyntaxKind.PowerOperator
+                ),
+                lua.createNumericLiteral(1),
+                lua.SyntaxKind.SubtractionOperator,
                 node
             );
         case "MAX_VALUE":
+            // (2 - 2 ^ -52) * 2 ^ 1023 = 1.7976931348623157e+308
             return lua.createBinaryExpression(
-                lua.createNumericLiteral(2),
-                lua.createNumericLiteral(1024),
-                lua.SyntaxKind.PowerOperator,
+                lua.createParenthesizedExpression(
+                    lua.createBinaryExpression(
+                        lua.createNumericLiteral(2),
+                        lua.createBinaryExpression(
+                            lua.createNumericLiteral(2),
+                            lua.createNumericLiteral(-52),
+                            lua.SyntaxKind.PowerOperator
+                        ),
+                        lua.SyntaxKind.SubtractionOperator
+                    )
+                ),
+                lua.createBinaryExpression(
+                    lua.createNumericLiteral(2),
+                    lua.createNumericLiteral(1023),
+                    lua.SyntaxKind.PowerOperator
+                ),
+                lua.SyntaxKind.MultiplicationOperator,
                 node
             );
 
diff --git a/test/unit/builtins/numbers.spec.ts b/test/unit/builtins/numbers.spec.ts
index aa3a8927d..9570e4af2 100644
--- a/test/unit/builtins/numbers.spec.ts
+++ b/test/unit/builtins/numbers.spec.ts
@@ -212,17 +212,23 @@ test.each(["42", "undefined"])("prototype call on nullable number (%p)", value =
 });
 
 test.each([
-    "Number.NEGATIVE_INFINITY <= Number.MIN_VALUE",
-    "Number.MIN_VALUE <= Number.MIN_SAFE_INTEGER",
-
-    "Number.MAX_SAFE_INTEGER <= Number.MAX_VALUE",
-    "Number.MAX_VALUE <= Number.POSITIVE_INFINITY",
+    // Full ordering: NEG_INF < MIN_SAFE < 0 < MIN_VALUE < EPSILON < MAX_SAFE < MAX_VALUE < POS_INF
+    "Number.NEGATIVE_INFINITY < Number.MIN_SAFE_INTEGER",
     "Number.MIN_SAFE_INTEGER < 0",
-
-    "0 < Number.EPSILON",
+    "0 < Number.MIN_VALUE",
+    "Number.MIN_VALUE < Number.EPSILON",
     "Number.EPSILON < Number.MAX_SAFE_INTEGER",
-])("Numer constants have correct relative sizes (%p)", comparison => {
-    util.testExpression(comparison).expectToEqual(true);
+    "Number.MAX_SAFE_INTEGER < Number.MAX_VALUE",
+    "Number.MAX_VALUE < Number.POSITIVE_INFINITY",
+
+    // Verify specific values
+    "Number.MIN_VALUE > 0",
+    "Number.MIN_SAFE_INTEGER === -(2**53 - 1)",
+    "Number.MAX_SAFE_INTEGER === 2**53 - 1",
+    "Number.MAX_SAFE_INTEGER + 1 !== Number.MAX_SAFE_INTEGER",
+    "Number.MIN_SAFE_INTEGER - 1 !== Number.MIN_SAFE_INTEGER",
+])("Number constants have correct relative sizes (%p)", comparison => {
+    util.testExpression(comparison).expectToMatchJsResult();
 });
 
 // https://github.com/TypeScriptToLua/TypeScriptToLua/issues/1629