Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NativeScript/NativeScript
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: evanfuture/NativeScript
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 2 commits
  • 1 file changed
  • 1 contributor

Commits on Sep 20, 2017

  1. Return true if user has consumed the action 

    Based on this: https://developer.android.com/reference/android/widget/TextView.OnEditorActionListener.html
And assuming that the developer will run dismissSoftInput in the owner.dismissSoftInput() only if they need to.
Returning False will close the keyboard regardless.
    @evanfuture
    evanfuture authored Sep 20, 2017
    Configuration menu
    Copy the full SHA
    f27b0d1 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #1 from evanfuture/nativescript-softinput-close-on… 

    …return

Return true if user has consumed the action
    @evanfuture
    evanfuture authored Sep 20, 2017
    Configuration menu
    Copy the full SHA
    d90df60 View commit details
    Browse the repository at this point in the history
Loading