java-gi/java-gi
1
7
Fork 1
Code Issues 1 Pull requests Releases 32 Activity Actions

Postprocessing changes #201

Merged
jwharm merged 2 commits from postprocessing-changes into main 2025-03-16 16:40:01 +01:00
Conversation 0 Commits 2 Files changed 18 +344 -246
jwharm commented 2025-03-16 16:39:48 +01:00 (Migrated from github.com)
Copy link

This PR merges a lot of the code that handles return values and out-parameters (take ownership, free native memory, check for null, etc). This code is now done in post-processing statements for both return values and out-parameters. As a result, all return values are now stored in a _returnValue variable before being returned. The post-processing statements (if any) are generated between those lines.

This not only improves the code generator internally (the MethodGenerator is now a lot simpler) but it also fixes bugs because out-parameters didn't always free native memory when they should. soup_form_decode_multipart is an example of this, that should now be fixed.

This PR merges a lot of the code that handles return values and out-parameters (take ownership, free native memory, check for null, etc). This code is now done in post-processing statements for both return values and out-parameters. As a result, all return values are now stored in a `_returnValue` variable before being returned. The post-processing statements (if any) are generated between those lines. This not only improves the code generator internally (the MethodGenerator is now a lot simpler) but it also fixes bugs because out-parameters didn't always free native memory when they should. `soup_form_decode_multipart` is an example of this, that should now be fixed.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something isn't working

  
dependencies

Pull requests that update a dependency file

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
github_actions

Pull requests that update GitHub Actions code

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
java

Pull requests that update Java code

  
question

Further information is requested

  
wontfix

This will not be worked on

No labels
bug
dependencies
documentation
duplicate
enhancement
github_actions
good first issue
help wanted
invalid
java
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
java-gi/java-gi!201
No description provided.