refactor(compiler-cli): decouple SymbolReference from AST nodes in te…#68181
Merged
kirjs merged 1 commit intoangular:mainfrom Apr 14, 2026
Merged
refactor(compiler-cli): decouple SymbolReference from AST nodes in te…#68181kirjs merged 1 commit intoangular:mainfrom
kirjs merged 1 commit intoangular:mainfrom
Conversation
…mplate checker To support the need to resolve symbols without full AST access (e.g. when using virtual files), this commit decouples `ReferenceSymbol` from `ts.ClassDeclaration`. Changes: - Updated `ReferenceSymbol.target` to use `SymbolReference` instead of `ts.ClassDeclaration`. - Removed `getReferenceTargetNode()` from `SymbolDirectiveMeta` and transitioned to `getSymbolReference()`. - Refactored `getTsSymbolOfReference` in `checker.ts` to handle `SymbolReference` and resolve it to a `ts.Symbol` using a position-optimized AST traversal. This avoids using the private `getTokenAtPosition` API and avoids full file scans by only traversing nodes containing the target position.
crisbeto
approved these changes
Apr 13, 2026
Contributor
Author
|
caretaker: unrelated failures |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…mplate checker
To support the need to resolve symbols without full AST access (e.g. when using virtual files), this commit decouples
ReferenceSymbolfromts.ClassDeclaration.Changes:
ReferenceSymbol.targetto useSymbolReferenceinstead ofts.ClassDeclaration.getReferenceTargetNode()fromSymbolDirectiveMetaand transitioned togetSymbolReference().getTsSymbolOfReferenceinchecker.tsto handleSymbolReferenceand resolve it to ats.Symbolusing a position-optimized AST traversal. This avoids using the privategetTokenAtPositionAPI and avoids full file scans by only traversing nodes containing the target position.