Skip to content

fix: not dev-installable using NPM#1124

Merged
rix0rrr merged 3 commits into10.xfrom
huijbers/version-conflict
Jun 30, 2022
Merged

fix: not dev-installable using NPM#1124
rix0rrr merged 3 commits into10.xfrom
huijbers/version-conflict

Conversation

@rix0rrr
Copy link
Copy Markdown
Contributor

@rix0rrr rix0rrr commented Jun 30, 2022

There are conflicting dependency ranges in package.json:

  "devDependencies": {
    "@types/jest": "^26.0.24",
    // ...
    "jest": "^27",
  },

These become visible when NPM 7 tries to install peerDependencies, which fails because of conflicts.

Fix and add a job that will ensure the version ranges are installable using NPM as well, not just yarn.

@rix0rrr rix0rrr requested a review from a team June 30, 2022 10:21
@rix0rrr rix0rrr self-assigned this Jun 30, 2022
Copy link
Copy Markdown

@Naumel Naumel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@rix0rrr rix0rrr merged commit aa977d9 into 10.x Jun 30, 2022
@rix0rrr rix0rrr deleted the huijbers/version-conflict branch June 30, 2022 12:01
@corymhall
Copy link
Copy Markdown
Contributor

https://github.com/Mergifyio backport 3.x

mergify Bot pushed a commit that referenced this pull request Jul 18, 2022
@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Jul 18, 2022

backport 3.x

✅ Backports have been created

Details

mergify Bot added a commit that referenced this pull request Jul 18, 2022
This is an automatic backport of pull request #1124 done by [Mergify](https://mergify.com).


---


<details>
<summary>Mergify commands and options</summary>

<br />

More conditions and actions can be found in the [documentation](https://docs.mergify.com/).

You can also trigger Mergify actions by commenting on this pull request:

- `@Mergifyio refresh` will re-evaluate the rules
- `@Mergifyio rebase` will rebase this PR on its base branch
- `@Mergifyio update` will merge the base branch into this PR
- `@Mergifyio backport <destination>` will backport this PR on `<destination>` branch

Additionally, on Mergify [dashboard](https://dashboard.mergify.com/) you can:

- look at your merge queues
- generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com
</details>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants