Clean up comments, add suppressWarning annotation#606
Merged
stleary merged 2 commits intostleary:masterfrom Aug 18, 2021
Merged
Clean up comments, add suppressWarning annotation#606stleary merged 2 commits intostleary:masterfrom
stleary merged 2 commits intostleary:masterfrom
Conversation
Owner
|
What problem does this code solve? Risks Changes to the API? Will this require a new release? Should the documentation be updated? Does it break the unit tests? Was any code refactored in this commit? Review status |
Owner
|
Starting 3 day comment window |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request addresses several issues in Javadoc formatting that were reported on LGTM
https://lgtm.com/projects/g/stleary/JSON-java/alerts?mode=tree
This also suppresses the "Equals method does not inspect argument type" alert by adding a
SuppressWarningannotation. This alert looks like a false positive. In fact,object == thisimplicitly check argument type -- ifobject's andthis's types are different, the condition would be false.