ci(jest-changed-files): enable mercurial related test on CI#12327
ci(jest-changed-files): enable mercurial related test on CI#12327SimenB merged 1 commit intojestjs:mainfrom mrazauskas:ci-mercurial-tests
mercurial related test on CI#12327Conversation
|
Awesome, thanks for taking the time to dig into this @mrazauskas! Flaky CI has been annoying for a long time |
Codecov Report
@@ Coverage Diff @@
## main #12327 +/- ##
=======================================
Coverage 67.25% 67.25%
=======================================
Files 330 330
Lines 17354 17354
Branches 5073 5073
=======================================
Hits 11671 11671
Misses 5651 5651
Partials 32 32 Continue to review full report at Codecov.
|
|
Is it passing every time now? 😅 |
|
Indeed. Runs with no issues. Perhaps let’s leave it for few of days and then I will force-push again. |
|
This specific one is not running, so it's not a flaky one. I'll land this, but understanding why other tests are failing sporadically would be nice... |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Split from #12322
One
mercurialrelated test is skipped on CI long time ago, but it works on GitHub Actions. It makes sense to enable it.Also there is another
hgtest which is sometimes failing on CI possibly due to flakiness (some timeout, race condition or so). Seemed that addingjest.retryTimesis making that test pass.Test plan
So here is the plan. First I am simply enabling the skipped test. Will try to force-push few times, if there is flakiness I will add
jest.retryTimesand will force-push few times to restart CI again. This way we can check ifjest.retryTimesis really necessary.