Skip to content

adding ts-jest mock util functions in jest-mock#12089

Merged
SimenB merged 9 commits intojestjs:mainfrom
k-rajat19:temp
Nov 29, 2021
Merged

adding ts-jest mock util functions in jest-mock#12089
SimenB merged 9 commits intojestjs:mainfrom
k-rajat19:temp

Conversation

@k-rajat19
Copy link
Copy Markdown
Contributor

@k-rajat19 k-rajat19 commented Nov 25, 2021 •
edited
Loading

Summary

This PR can close #9534 which was opened as a feature request by @ahnpnl

This PR includes -

there is also another proposal for partialMocked in kulshekhar/ts-jest#1065 which can be added after these changes are approved.

Any suggestions/ changes which can help in closing the above issue are most welcome.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Nov 25, 2021 •
edited
Loading

Codecov Report

Merging #12089 (93234bd) into main (1f813fa) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #12089      +/-   ##
==========================================
- Coverage   68.89%   68.89%   -0.01%     
==========================================
  Files         324      324              
  Lines       16669    16672       +3     
  Branches     4814     4814              
==========================================
+ Hits        11484    11486       +2     
- Misses       5152     5153       +1     
  Partials       33       33
Impacted Files Coverage Δ
packages/jest-mock/src/index.ts 85.09% <100.00%> (+0.10%) ⬆️
packages/expect/src/utils.ts 95.85% <0.00%> (-0.52%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f813fa...93234bd. Read the comment docs.

@ahnpnl
Copy link
Copy Markdown
Contributor

ahnpnl commented Nov 25, 2021

Documentation https://github.com/facebook/jest/tree/main/docs would need to be updated as well as CHANGELOG too :)

@k-rajat19
Copy link
Copy Markdown
Contributor Author

k-rajat19 commented Nov 25, 2021 •
edited
Loading

Typescript compiler is not able to validate definition files
this may be due to ts-jest type MockedFunction ?

@ahnpnl
Copy link
Copy Markdown
Contributor

ahnpnl commented Nov 25, 2021

The whole mocked from ts-jest relies partially on @types/jest. I think the TypeScript build failure is connected to that. Probably because @types/jest isn't a direct dependency of jest-mock package.

SimenB
SimenB approved these changes Nov 29, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@SimenB SimenB merged commit ee24dfc into jestjs:main Nov 29, 2021
This was referenced Dec 5, 2021
Closed
Closed
@ahnpnl ahnpnl mentioned this pull request Dec 5, 2021
Closed
@pbrisbin pbrisbin mentioned this pull request Dec 6, 2021
Merged
This was referenced Dec 7, 2021
Merged
Merged
@hudochenkov hudochenkov mentioned this pull request Dec 7, 2021
Closed
@marekdedic marekdedic mentioned this pull request Dec 7, 2021
Merged
@k-rajat19 k-rajat19 mentioned this pull request Dec 8, 2021
Merged
boonya added a commit to boonya/react-hook-form-validation that referenced this pull request Dec 18, 2021
@boonya
All dependecies are up to date + jest.mocked instead of ts-jest mocke…
837b6fe 
…d due to jestjs/jest#12089
@boonya boonya mentioned this pull request Dec 18, 2021
Closed
@G-Rath G-Rath mentioned this pull request Dec 19, 2021
Closed
8 tasks
@k-rajat19 k-rajat19 mentioned this pull request Dec 19, 2021
Merged
8 tasks
@y-lakhdar y-lakhdar mentioned this pull request Dec 29, 2021
Merged
3 tasks
@mikemaccana
Copy link
Copy Markdown
Contributor

mikemaccana commented Jan 5, 2022 •
edited
Loading

For those a who came here from the warning:

@boonya boonya mentioned this pull request Jan 12, 2022
Merged
@arb000r arb000r mentioned this pull request Jan 20, 2022
Merged
12 tasks
@jo-sm jo-sm mentioned this pull request Jan 25, 2022
Merged
@byCedric byCedric mentioned this pull request Jan 27, 2022
Merged
3 tasks
@joshhunt joshhunt mentioned this pull request Jan 31, 2022
Merged
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 5, 2022

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@SimenB SimenB SimenB approved these changes

Assignees

No one assigned

Labels

cla signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Include ts-jest mock util functions in jest core

6 participants

@k-rajat19 @codecov-commenter @ahnpnl @mikemaccana @SimenB @facebook-github-bot