Skip to content

feat(expect): add asymmetric matcher expect.closeTo#12243

Merged
SimenB merged 3 commits intojestjs:mainfrom
Biki-das:doc-work
Feb 5, 2022
Merged

feat(expect): add asymmetric matcher expect.closeTo#12243
SimenB merged 3 commits intojestjs:mainfrom
Biki-das:doc-work

Conversation

@Biki-das
Copy link
Copy Markdown
Contributor

@Biki-das Biki-das commented Jan 15, 2022

added feature for #12242

also added a test for the same in packages/expect/src/__tests__/asymmetricMatchers.test.ts

@Biki-das Biki-das changed the title Add:-Added asymmetric matcher Add:-Added asymmetric matcher to expect.closeTo Jan 15, 2022
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jan 15, 2022 •
edited
Loading

Codecov Report

Merging #12243 (3894028) into main (4f4be57) will increase coverage by 0.02%.
The diff coverage is 86.20%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #12243      +/-   ##
==========================================
+ Coverage   67.52%   67.55%   +0.02%     
==========================================
  Files         328      328              
  Lines       17244    17272      +28     
  Branches     5069     5077       +8     
==========================================
+ Hits        11644    11668      +24     
- Misses       5567     5571       +4     
  Partials       33       33
Impacted Files Coverage Δ
packages/expect/src/asymmetricMatchers.ts 83.44% <85.18%> (+0.39%) ⬆️
packages/expect/src/index.ts 91.33% <100.00%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f4be57...3894028. Read the comment docs.

@Biki-das
Copy link
Copy Markdown
Contributor Author

Biki-das commented Jan 24, 2022

@SimenB i am excited for this one to land, looking forward to your feedback

SimenB
SimenB requested changes Feb 5, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me! normally we wouldn't add more matchers, but this is just an asymmetric version of a matcher we already have.

can you add a changelog entry?

@Biki-das
Copy link
Copy Markdown
Contributor Author

Biki-das commented Feb 5, 2022

works for me! normally we wouldn't add more matchers, but this is just an asymmetric version of a matcher we already have.

can you add a changelog entry?

sure

@SimenB SimenB linked an issue Feb 5, 2022 that may be closed by this pull request
Adding asymmetric matcher expect.closeTo #12242
Closed
SimenB
SimenB approved these changes Feb 5, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@SimenB SimenB changed the title Add:-Added asymmetric matcher to expect.closeTo feat(expect): add asymmetric matcher expect.closeTo Feb 5, 2022
@SimenB SimenB merged commit 5160ae0 into jestjs:main Feb 5, 2022
@mrazauskas mrazauskas mentioned this pull request Feb 5, 2022
Merged
@SimenB SimenB mentioned this pull request Feb 23, 2022
Closed
@munierujp munierujp mentioned this pull request Feb 24, 2022
Closed
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 8, 2022

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Mar 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@SimenB SimenB SimenB approved these changes

Assignees

No one assigned

Labels

cla signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Adding asymmetric matcher expect.closeTo

4 participants

@Biki-das @codecov-commenter @SimenB @facebook-github-bot