fix(expect): add type definitions for asymmetric closeTo matcher#12304
Merged
SimenB merged 2 commits intojestjs:mainfrom Feb 6, 2022
mrazauskas:fix-add-closeTo-typings
Merged
fix(expect): add type definitions for asymmetric closeTo matcher#12304SimenB merged 2 commits intojestjs:mainfrom mrazauskas:fix-add-closeTo-typings
closeTo matcher#12304SimenB merged 2 commits intojestjs:mainfrom
mrazauskas:fix-add-closeTo-typings
Conversation
Codecov Report
@@ Coverage Diff @@
## main #12304 +/- ##
==========================================
- Coverage 67.29% 67.25% -0.05%
==========================================
Files 329 329
Lines 17336 17346 +10
Branches 5074 5074
==========================================
- Hits 11667 11666 -1
- Misses 5637 5648 +11
Partials 32 32
Continue to review full report at Codecov.
|
SimenB
approved these changes
Feb 6, 2022
Member
SimenB
left a comment
There was a problem hiding this comment.
sweet, thanks for keeping an eye out!
Contributor
|
thanks @mrazauskas. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#12243 landed with new asymmetric
closeTomatcher, but seems like type definitions went missing. Easy to fix (;Test plan
Type tests included.