Use Object.keys as Object.values is not supported in node<7#295
Merged
fb55 merged 1 commit intofb55:masterfrom Oct 9, 2020
Merged
Use Object.keys as Object.values is not supported in node<7#295fb55 merged 1 commit intofb55:masterfrom
fb55 merged 1 commit intofb55:masterfrom
Conversation
Object.values was introduced in 138b101 and it is not supported in node.js until version 7, so it's a mismatch with what's declared in the `engines` section of package.json (node >= 6).
|
@here any update? |
Contributor
Author
|
@macmilan So far I had to pin the dependency to a last-working version ( |
|
@rails/webpacker uses this in its' dependency tree and we can't deploy because of it. Any way we can force it to use 3.3.0 ? |
Owner
Contributor
Author
|
Awesome, thanks for merging @fb55! 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Object.values was introduced in 138b101 and it is not supported in node.js until version 7, so it's a mismatch with what's declared in the
enginessection of package.json (node >= 6).This fixes #294