Skip to content

fix(transport): increase ReadIdleTimeout#1028

Merged
codyoss merged 1 commit intogoogleapis:masterfrom
tritone:ping-timeout
May 18, 2021
Merged

fix(transport): increase ReadIdleTimeout#1028
codyoss merged 1 commit intogoogleapis:masterfrom
tritone:ping-timeout

Conversation

@tritone
Copy link
Copy Markdown
Contributor

@tritone tritone commented May 18, 2021

Increase this value to comply with CFE rate limit on pings.

Closes googleapis/google-cloud-go#4121

Increase this value to comply with CFE rate limit on pings.

Closes googleapis/google-cloud-go#4121
@tritone tritone requested a review from yoshi-approver as a code owner May 18, 2021 22:53
@tritone tritone requested a review from a team May 18, 2021 22:53
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label May 18, 2021
@tritone tritone requested a review from shollyman May 18, 2021 22:54
Copy link
Copy Markdown
Contributor

@shollyman shollyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disclaimer on LGTM: I don't claim to have full awareness of the magic here, but that seems like a more sensible default generally.

Copy link
Copy Markdown
Member

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codyoss codyoss merged commit b3cd013 into googleapis:master May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bigquery: TestIntegration_InsertAndReadStructs failed

3 participants