Skip to content
This repository was archived by the owner on Mar 4, 2026. It is now read-only.

fix: type of QuerySnapshot.docChanges() should be generic#1484

Merged
schmidt-sebastian merged 3 commits intomasterfrom
mrschmidt/generic
Apr 28, 2021
Merged

fix: type of QuerySnapshot.docChanges() should be generic#1484
schmidt-sebastian merged 3 commits intomasterfrom
mrschmidt/generic

Conversation

@schmidt-sebastian
Copy link
Copy Markdown
Contributor

@schmidt-sebastian schmidt-sebastian commented Apr 26, 2021 •
edited
Loading

Fixes #1483

@schmidt-sebastian schmidt-sebastian requested review from a team April 26, 2021 15:35
@product-auto-label product-auto-label bot added the api: firestore Issues related to the googleapis/nodejs-firestore API. label Apr 26, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Apr 26, 2021
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 26, 2021 •
edited
Loading

Codecov Report

Merging #1484 (e0982c8) into master (685e75c) will increase coverage by 0.02%.
The diff coverage is 99.17%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1484      +/-   ##
==========================================
+ Coverage   98.20%   98.22%   +0.02%     
==========================================
  Files          32       32              
  Lines       19502    20052     +550     
  Branches     1363     1390      +27     
==========================================
+ Hits        19152    19697     +545     
- Misses        346      351       +5     
  Partials        4        4
Impacted Files Coverage Δ
dev/src/v1beta1/firestore_client.ts 97.93% <98.85%> (+0.19%) ⬆️
dev/src/backoff.ts 98.29% <100.00%> (ø)
dev/src/bulk-writer.ts 100.00% <100.00%> (ø)
dev/src/index.ts 95.45% <100.00%> (+<0.01%) ⬆️
dev/src/query-partition.ts 100.00% <100.00%> (ø)
dev/src/rate-limiter.ts 98.85% <100.00%> (ø)
dev/src/reference.ts 99.21% <100.00%> (ø)
dev/src/timestamp.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7a9f44...e0982c8. Read the comment docs.

@schmidt-sebastian schmidt-sebastian added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 26, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 28, 2021
@schmidt-sebastian schmidt-sebastian merged commit 3ed1929 into master Apr 28, 2021
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt/generic branch April 28, 2021 17:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@thebrianchen thebrianchen thebrianchen approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@schmidt-sebastian schmidt-sebastian

Labels

api: firestore Issues related to the googleapis/nodejs-firestore API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

The return type of docChanges in QuerySnapshot is not generic

3 participants

@schmidt-sebastian @thebrianchen @yoshi-kokoro