This repository was archived by the owner on Mar 4, 2026. It is now read-only.
fix: do not leak credentials in Firestore.toJSON()#1522
Merged
schmidt-sebastian merged 1 commit intomasterfrom May 27, 2021
Merged
fix: do not leak credentials in Firestore.toJSON()#1522schmidt-sebastian merged 1 commit intomasterfrom
schmidt-sebastian merged 1 commit intomasterfrom
Conversation
1c6fe15 to
7b01e75
Compare
thebrianchen
approved these changes
May 27, 2021
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
May 27, 2021
🤖 I have created a release \*beep\* \*boop\* --- ### [4.12.2](https://www.github.com/googleapis/nodejs-firestore/compare/v4.12.1...v4.12.2) (2021-05-27) ### Bug Fixes * do not leak credentials in Firestore.toJSON() ([#1522](https://www.github.com/googleapis/nodejs-firestore/issues/1522)) ([791310f](https://www.github.com/googleapis/nodejs-firestore/commit/791310ff4b0a828ca6d1f5c0fa03a110972afb1f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1481