Skip to content
This repository was archived by the owner on Mar 3, 2026. It is now read-only.

docs: add AbortIncompleteMultipartUpload to docs for addLifecycleRule#1854

Merged
shaffeeullah merged 1 commit intogoogleapis:mainfrom
ddelgrosso1:olm-doc-update
Jun 7, 2022
Merged

docs: add AbortIncompleteMultipartUpload to docs for addLifecycleRule#1854
shaffeeullah merged 1 commit intogoogleapis:mainfrom
ddelgrosso1:olm-doc-update

Conversation

@ddelgrosso1
Copy link
Copy Markdown
Contributor

@ddelgrosso1 ddelgrosso1 commented Apr 8, 2022

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@ddelgrosso1 ddelgrosso1 requested review from a team and BrennaEpp April 8, 2022 13:55
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: storage Issues related to the googleapis/nodejs-storage API. labels Apr 8, 2022
@shaffeeullah
Copy link
Copy Markdown
Contributor

shaffeeullah commented Apr 8, 2022

@ddelgrosso1 should we label this do not merge until the feature is released?

@ddelgrosso1 ddelgrosso1 added do not merge Indicates a pull request not ready for merge, due to either quality or timing. owlbot:run Add this label to trigger the Owlbot post processor. labels Apr 8, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 8, 2022
@shaffeeullah shaffeeullah removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jun 7, 2022
@shaffeeullah shaffeeullah merged commit 594e7da into googleapis:main Jun 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@BrennaEpp BrennaEpp Awaiting requested review from BrennaEpp

1 more reviewer

@shaffeeullah shaffeeullah shaffeeullah approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: storage Issues related to the googleapis/nodejs-storage API. size: xs Pull request size is extra small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ddelgrosso1 @shaffeeullah