Skip to content
This repository was archived by the owner on Mar 3, 2026. It is now read-only.

fix: capture and throw on non-existent files#1969

Merged
danielbankhead merged 2 commits intomainfrom
fix-unhandled-upload-read-rejection
May 25, 2022
Merged

fix: capture and throw on non-existent files#1969
danielbankhead merged 2 commits intomainfrom
fix-unhandled-upload-read-rejection

Conversation

@danielbankhead
Copy link
Copy Markdown
Contributor

Fixes #1968 🦕

@danielbankhead danielbankhead requested review from a team May 25, 2022 20:29
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: storage Issues related to the googleapis/nodejs-storage API. labels May 25, 2022
- TS doesn't support the pipeline `value` return in the callback yet...
@sethvargo
Copy link
Copy Markdown

Thanks!

@danielbankhead danielbankhead merged commit 52d81c0 into main May 25, 2022
@danielbankhead danielbankhead deleted the fix-unhandled-upload-read-rejection branch May 25, 2022 20:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: storage Issues related to the googleapis/nodejs-storage API. size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

v6.0.0 throws exceptions off main thread during upload

4 participants