[6.5] Document the impact of fixing time units for RetryMiddleware#2570
Merged
gmponos merged 1 commit intoguzzle:6.5from May 18, 2020
Merged
[6.5] Document the impact of fixing time units for RetryMiddleware#2570gmponos merged 1 commit intoguzzle:6.5from
gmponos merged 1 commit intoguzzle:6.5from
Conversation
Related to guzzle#2132 A fraction of use cases will expect low timeouts or no timeouts. Make it clearer that those applications should override the defaults of the middleware if upgrading to 6.5.0
gmponos
approved these changes
May 15, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #2132
A fraction of use cases will expect low timeouts or no timeouts.
Make it clearer that those applications should override the defaults
of the middleware if upgrading to 6.5.0