Fix for TypeError in python 3.7 and pytest#113
Merged
kvesteri merged 1 commit intopython-validators:masterfrom Jan 24, 2019
Merged
Fix for TypeError in python 3.7 and pytest#113kvesteri merged 1 commit intopython-validators:masterfrom
kvesteri merged 1 commit intopython-validators:masterfrom
Conversation
pytest with throw this error when running in version 3.7:
"TypeError: catching classes that do not inherit from BaseException is not allowed"
Changing the inheritance from object to Exception will fix this and is compatible back to version 2.7 and should cause no issues.
This pytest sample test that will trigger the error in python 3.7:
def test_init_with_bad_url(self):
with pytest.raises(validators.ValidationFailure):
assert True
Collaborator
|
Thanks for the PR! 🚋 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pytest with throw this error when running in version 3.7:
"TypeError: catching classes that do not inherit from BaseException is not allowed"
Changing the inheritance from object to Exception will fix this and is compatible back to version 2.7 and should cause no issues.
This pytest sample test that will trigger the error in python 3.7:
def test_init_with_bad_url(self):
with pytest.raises(validators.ValidationFailure):
assert True