Skip to content

chore(dep): remove unneeded dev dep acron#1668

Merged
mastermatt merged 1 commit intonock:nextfrom
mastermatt:chore/remove-arcorn
Aug 17, 2019
Merged

chore(dep): remove unneeded dev dep acron#1668
mastermatt merged 1 commit intonock:nextfrom
mastermatt:chore/remove-arcorn

Conversation

@mastermatt
Copy link
Copy Markdown
Member

closes: #1666

@paulmelnikow
Copy link
Copy Markdown
Member

This makes sense to me. I've sometimes seen warnings about missing dependencies when acorn isn't installed, though I ran an npm install on this branch and saw none of those, so I think it's good!

@mastermatt mastermatt force-pushed the chore/remove-arcorn branch from a10d444 to bd63838 Compare August 16, 2019 03:01
@mastermatt mastermatt merged commit 82a3cae into nock:next Aug 17, 2019
@mastermatt mastermatt deleted the chore/remove-arcorn branch August 18, 2019 01:40
@nockbot
Copy link
Copy Markdown
Collaborator

nockbot commented Aug 20, 2019

🎉 This PR is included in version 11.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

gr2m pushed a commit that referenced this pull request Sep 4, 2019
gr2m pushed a commit that referenced this pull request Sep 4, 2019
gr2m pushed a commit that referenced this pull request Sep 5, 2019
juninmd pushed a commit to juninmd/nock that referenced this pull request Mar 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants