chore(test) update/remove client specific tests#2167
Merged
mastermatt merged 1 commit intonock:mainfrom Mar 7, 2021
Merged
Conversation
There were three tests simply using `superagent`, but not testing anything Nock related, so they were removed.
Two tests were using `request`, but were easily converted to `got`.
One test was testing an issue related to `request` strictSSL. The underlying issue was discovered, commented, and the test updated to use `https` instead.
And one test ("test request timeout option") wasn't actually testing anything Nock related, so it was removed.
6 tasks
|
🎉 This PR is included in version 13.0.11 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Mar 8, 2021
Closed
This was referenced Mar 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were three tests simply using
superagent, but not testing anything Nock related, so they were removed.Two tests were using
request, but were easily converted togot.One test was testing an issue related to
requeststrictSSL. The underlying issue was discovered, commented, and the test updated to usehttpsinstead.And one test ("test request timeout option") wasn't actually testing anything Nock related, so it was removed.
Closes: #1777