Replies: 3 comments 3 replies
-
|
Hello, the fact that developers use this and it's uncaught in your process is a feedback about your code review - it should be more thorough and these things shouldn't slip through. If we offered a way to disable this feature, your developers would just enable it again. It would be a cat-and-mouse game. To catch this problem, you can write a simple bash script that calls |
Beta Was this translation helpful? Give feedback.
-
|
I agree that the code review process can be improved as well. I would see this option to disable in-line ignore annotations as a helpful feature because than you could enforce developers to use the baseline file which you can easily add to the |
Beta Was this translation helpful? Give feedback.
-
@ondrejmirtes Not if your developers don't have access to the phpstan.neon configuration file -- you can set things up so they don't. Having a setting to disable inline ignore is essential, in my opinion, for the exact case where developers abuse it and use it to bypass PHPStan checks run in the pipeline.
It would be extremely helpful, essential in my opinion, for PHPStan to have this too. |
Beta Was this translation helpful? Give feedback.
-
|
|
Beta Was this translation helpful? Give feedback.
-
|
@ondrejmirtes not if those contain comments, so it's not fully an option to disable |
Beta Was this translation helpful? Give feedback.
-
|
These do not understand comments that way. ignore-line and ignore-next-line are always rejected with this option |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
-
Hello!
Is there maybe a setting to disable
phpstan-ignore-next-linePHPDoc parsing? What do you think about implementing one like that, would that be useful?We run PHPStan at the highest possible level. Sometimes developers use
phpstan-ignore-next-linecomment instead of fixing issues. I thought that it might be a good idea to disable that to enforce the rules on the codebase, but I don't see such a possibility with the current version.Beta Was this translation helpful? Give feedback.
All reactions