fix: takeWhile Boolean constructor types#6633
Conversation
|
Not sure if I understood correctly, but looks like current signature behaves correct? Takewhile doesn't change what source emits but only limits when to stop emit. Would you mind explain bit as I may miss something? |
If the of('foo', 'bar', null).pipe(
takeWhile(Boolean)
)will only emit That's why I think that it makes sense to change the typings of the Boolean constructor (when the |
e030311 to
1dbe556
Compare
|
Thank you, @josepot! |
I think that the typings for the Boolean constructor of
takeWhileare off... For instance, I think that the following dtslint test:should expect this, instead:
The goal of this PR is to make the Boolean constructor typings of
takeWhile(when theinclusiveflag is set tofalse) consistent with the typings offilter.