Add :parser_options config option#194
Merged
rgrove merged 1 commit intorgrove:masterfrom Sep 7, 2019
austin-wang:austin-wang/nokogumbo-parsing-options
Merged
Add :parser_options config option#194rgrove merged 1 commit intorgrove:masterfrom austin-wang:austin-wang/nokogumbo-parsing-options
rgrove merged 1 commit intorgrove:masterfrom
austin-wang:austin-wang/nokogumbo-parsing-options
Conversation
rgrove
approved these changes
Sep 7, 2019
Owner
rgrove
left a comment
There was a problem hiding this comment.
This looks great! Thanks for the tests and docs. I’ll merge this soon.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
Sanitize.fragmentis called with a string representation of a html document that has nesting that exceedsNokogumbo::DEFAULT_MAX_TREE_DEPTH(400), the following exception is raised:This pull request adds a new configuration option —
:parser_options, that will be supplied tonokogumbowhen callingNokogiri::HTML5.fragment. The supported properties in:parser_optionsare documented here.