Skip to content

🌐 Add Japanese translation for History Design and Future#2002

Merged
tiangolo merged 6 commits intofastapi:masterfrom
komtaki:translation/add-japanese-doc-history-design-future
Oct 18, 2020
Merged

🌐 Add Japanese translation for History Design and Future#2002
tiangolo merged 6 commits intofastapi:masterfrom
komtaki:translation/add-japanese-doc-history-design-future

Conversation

@komtaki
Copy link
Copy Markdown
Contributor

@komtaki komtaki commented Sep 2, 2020 •
edited
Loading

This PR translates the history-design-future.md to Japanese.

According to the issue: #1572

Thanks!!

@komtaki komtaki changed the title Add japanese doc history-design-future.md Add history-design-future.md Japanese ver. Sep 2, 2020
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 2, 2020 •
edited
Loading

Codecov Report

Merging #2002 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #2002   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          239       239           
  Lines         7079      7079           
=========================================
  Hits          7079      7079

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb55d7c...883fc4b. Read the comment docs.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 2, 2020

📝 Docs preview for commit 32f62e7cfd14750e2e7e876ca36a20cf12dd72bb at: https://5f4f61f91b2e0974afc3ac0a--fastapi.netlify.app

@komtaki komtaki force-pushed the translation/add-japanese-doc-history-design-future branch from 32f62e7 to 0cba83c Compare September 4, 2020 13:25
@komtaki komtaki marked this pull request as ready for review September 4, 2020 13:26
@komtaki komtaki mentioned this pull request Sep 4, 2020
Closed
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 4, 2020

📝 Docs preview for commit 0cba83c at: https://5f5267a6a13a211201097a70--fastapi.netlify.app

tokusumi
tokusumi suggested changes Sep 12, 2020
View reviewed changes
Comment thread docs/ja/docs/history-design-future.md Outdated
Comment thread docs/ja/docs/history-design-future.md Outdated
Comment thread docs/ja/docs/history-design-future.md Outdated
Comment thread docs/ja/docs/history-design-future.md Outdated
Comment thread docs/ja/docs/history-design-future.md Outdated
Comment thread docs/ja/docs/history-design-future.md Outdated
Comment thread docs/ja/docs/history-design-future.md Outdated
@komtaki
Copy link
Copy Markdown
Contributor Author

komtaki commented Sep 13, 2020

@tokusumi

Thanks for the review!! 👍
I fixed everything. So, check my fix please.

tokusumi
tokusumi approved these changes Sep 13, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@tokusumi tokusumi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 13, 2020

📝 Docs preview for commit 5054408 at: https://5f5db8ada9ea4d5136e47462--fastapi.netlify.app

Attsun1031
Attsun1031 reviewed Sep 27, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@Attsun1031 Attsun1031 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your translation ! Most of the translation felt okay,

I commented only about the consistency with alternatives.md translation.

Comment thread docs/ja/docs/history-design-future.md Outdated
Comment thread docs/ja/docs/history-design-future.md
@komtaki
Copy link
Copy Markdown
Contributor Author

komtaki commented Sep 27, 2020 •
edited
Loading

@Attsun1031

Thank you for your review. 👍
I fixed to match to #2043

Please check my fix.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 27, 2020

📝 Docs preview for commit 78c5948 at: https://5f70578e4936ac987f449091--fastapi.netlify.app

Attsun1031
Attsun1031 approved these changes Sep 27, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@Attsun1031 Attsun1031 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

@tokusumi
Copy link
Copy Markdown
Contributor

tokusumi commented Sep 29, 2020

Hi, @tiangolo
This PR has been approved by two reviewers (github actions to label approved PR didn't work, though).
Would you like to require something more for this to be merged?

@Mause
Copy link
Copy Markdown
Contributor

Mause commented Sep 29, 2020

I believe @tiangolo is currently moving houses, so you'll have to be patient

@tokusumi
Copy link
Copy Markdown
Contributor

tokusumi commented Sep 29, 2020

Oops. I'm really sorry for annoying notification 🙇

@tiangolo tiangolo added awaiting-review lang-all Translations lang-ja Japanese translations labels Oct 15, 2020
@tiangolo tiangolo changed the title Add history-design-future.md Japanese ver. 🌐 Add Japanese translation for History Design and Future Oct 18, 2020
@tiangolo tiangolo merged commit f2c565d into fastapi:master Oct 18, 2020
@tiangolo
Copy link
Copy Markdown
Member

tiangolo commented Oct 18, 2020

Great! Thank you @komtaki ! 🙇 ☕

Thanks for the reviews @Attsun1031 and @tokusumi ! 🍰 🤓

And thanks @Mause for helping with the clarification! 😄 Indeed, finding a flat in Berlin is quite difficult and has a bunch of complications... I'm still waiting for the internet connection to be installed in my house 😅

But also thanks @tokusumi for pointing out the broken bot 🤦‍♂️ I wrote one to replace it and it should work fine from now on 🤖 🚀

@komtaki komtaki deleted the translation/add-japanese-doc-history-design-future branch October 19, 2020 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@Attsun1031 Attsun1031 Attsun1031 approved these changes

@tokusumi tokusumi tokusumi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved-2 lang-all Translations lang-ja Japanese translations

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@komtaki @tokusumi @Mause @tiangolo @Attsun1031