Skip to content

📝 Add Japanese translation for Tutorial - Security - First Steps#2153

Merged
tiangolo merged 5 commits intofastapi:masterfrom
komtaki:translation/add-japanese-doc-security-first-step
Nov 5, 2020
Merged

📝 Add Japanese translation for Tutorial - Security - First Steps#2153
tiangolo merged 5 commits intofastapi:masterfrom
komtaki:translation/add-japanese-doc-security-first-step

Conversation

@komtaki
Copy link
Copy Markdown
Contributor

@komtaki komtaki commented Oct 10, 2020 •
edited
Loading

This PR translates the tutorial/security/first-steps.md to Japanese.

According to the issue: #1572

I merged the PR for dependency: #1656
So, please check the commit : 18f28de

Thanks!!

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 10, 2020

📝 Docs preview for commit 18f28de1e84cc3484a7258d738c1083363bccce2 at: https://5f81b378b8a91f84cb2a5ca9--fastapi.netlify.app

@komtaki komtaki force-pushed the translation/add-japanese-doc-security-first-step branch from 18f28de to d50a9fc Compare October 10, 2020 13:45
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 10, 2020 •
edited
Loading

Codecov Report

Merging #2153 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #2153   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          239       239           
  Lines         7079      7079           
=========================================
  Hits          7079      7079

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dca9cc3...4de1bbe. Read the comment docs.

@komtaki komtaki marked this pull request as ready for review October 10, 2020 14:06
@komtaki komtaki mentioned this pull request Oct 10, 2020
Closed
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 10, 2020

📝 Docs preview for commit d50a9fc8405722f34445ab91aa1a4271482548e9 at: https://5f81c1bb1a19b4907d0812a2--fastapi.netlify.app

Attsun1031
Attsun1031 reviewed Oct 11, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@Attsun1031 Attsun1031 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your tough work!
Please check comments I made.

Comment thread docs/ja/docs/tutorial/security/first-steps.md Outdated
Comment thread docs/ja/docs/tutorial/security/first-steps.md Outdated
Comment thread docs/ja/docs/tutorial/security/first-steps.md Outdated
Comment thread docs/ja/docs/tutorial/security/first-steps.md Outdated
Comment thread docs/ja/docs/tutorial/security/first-steps.md Outdated
Comment thread docs/ja/docs/tutorial/security/first-steps.md Outdated
Comment thread docs/ja/docs/tutorial/security/first-steps.md Outdated
Comment thread docs/ja/docs/tutorial/security/first-steps.md Outdated
Comment thread docs/ja/docs/tutorial/security/first-steps.md Outdated
Comment thread docs/ja/docs/tutorial/security/first-steps.md Outdated
@komtaki
Copy link
Copy Markdown
Contributor Author

komtaki commented Oct 11, 2020

@Attsun1031

Thank you for your review. 👍
I applied your suggestion. So, check please.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 11, 2020

📝 Docs preview for commit 905fd553c2a1c51915bf6dcad5b397d17faf9622 at: https://5f82e8bf158e4bb48deff0f2--fastapi.netlify.app

Attsun1031
Attsun1031 approved these changes Oct 13, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@Attsun1031 Attsun1031 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@komtaki komtaki force-pushed the translation/add-japanese-doc-security-first-step branch from 905fd55 to 819787a Compare October 19, 2020 14:52
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 19, 2020

📝 Docs preview for commit 819787a at: https://5f8dadb9ea9a9074c94a7f34--fastapi.netlify.app

tokusumi
tokusumi suggested changes Oct 29, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@tokusumi tokusumi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for tough work! I commented some improvements (there are a too tiny changes 😅 )

Comment thread docs/ja/docs/tutorial/security/first-steps.md Outdated
Comment thread docs/ja/docs/tutorial/security/first-steps.md Outdated
Comment thread docs/ja/docs/tutorial/security/first-steps.md Outdated
Comment thread docs/ja/docs/tutorial/security/first-steps.md Outdated
Comment thread docs/ja/docs/tutorial/security/first-steps.md Outdated
Comment thread docs/ja/docs/tutorial/security/first-steps.md Outdated
Comment thread docs/ja/docs/tutorial/security/first-steps.md

**FastAPI**は、これらのセキュリティ機能を実装するために、抽象度の異なる複数のツールを提供しています。

この例では、**Bearer**トークンを使用して**OAuth2**を**パスワード**フローで使用します。これには`OAuth2PasswordBearer`クラスを使用します。
Copy link
Copy Markdown
Contributor

@tokusumi tokusumi Oct 29, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

password flowの訳は「パスワードのフロー」か「パスワードフロー」のどちらかに統一したほうがいいと思います。後者の方が適切に感じます。

Copy link
Copy Markdown
Contributor Author

@komtaki komtaki Nov 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

統一しました 🙇

Comment thread docs/ja/docs/tutorial/security/first-steps.md Outdated
Comment thread docs/ja/docs/tutorial/security/first-steps.md Outdated
Comment thread docs/ja/docs/tutorial/security/first-steps.md Outdated
@komtaki
Copy link
Copy Markdown
Contributor Author

komtaki commented Nov 2, 2020

@tokusumi

Thanks for your review. I applied your suggestions and fixed. 👍
So, check please.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 2, 2020

📝 Docs preview for commit 4de1bbe at: https://5fa01582e50d1a332ed9ac79--fastapi.netlify.app

tokusumi
tokusumi approved these changes Nov 2, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@tokusumi tokusumi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tiangolo tiangolo changed the title Add tutorial/security/first-steps.md Japanese ver. 📝 Add Japanese translation for Tutorial - Security - First Steps Nov 5, 2020
@tiangolo tiangolo merged commit 104ee63 into fastapi:master Nov 5, 2020
@tiangolo
Copy link
Copy Markdown
Member

tiangolo commented Nov 5, 2020

Awesome, thank you @komtaki ! 🍰 ☕

And thanks @tokusumi and @Attsun1031 for the reviews! 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@Attsun1031 Attsun1031 Attsun1031 approved these changes

@tokusumi tokusumi tokusumi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved-2 hacktoberfest-accepted lang-all Translations lang-ja Japanese translations

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@komtaki @tiangolo @Attsun1031 @tokusumi