Skip to content

📝 Add external link to "FastAPI for Flask Users"#2280

Merged
tiangolo merged 3 commits intofastapi:masterfrom
amitness:patch-1
Feb 7, 2021
Merged

📝 Add external link to "FastAPI for Flask Users"#2280
tiangolo merged 3 commits intofastapi:masterfrom
amitness:patch-1

Conversation

@amitness
Copy link
Copy Markdown
Contributor

@amitness amitness commented Nov 1, 2020

I have added a link to my article FastAPI for Flask Users in the external links section of documentation.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 1, 2020

📝 Docs preview for commit 5ec2a34 at: https://5f9e8ff8a392bfc00adfcd35--fastapi.netlify.app

ycd
ycd suggested changes Nov 1, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@ycd ycd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do not have an alphabetical order. The order is first-come-first-serve, so to be fair, please add this to the end.

@amitness
Copy link
Copy Markdown
Contributor Author

amitness commented Nov 2, 2020

@ycd I've migrated it to the end of the list. Should adhere to the FCFS rule now.

@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 2, 2020 •
edited
Loading

Codecov Report

Merging #2280 (a748ba1) into master (7d7289a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #2280   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          240       240           
  Lines         7101      7101           
=========================================
  Hits          7101      7101

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b53c443...a748ba1. Read the comment docs.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 2, 2020

📝 Docs preview for commit c7de6f2 at: https://5f9fa7c380012668801451a6--fastapi.netlify.app

@ArcLightSlavik ArcLightSlavik mentioned this pull request Nov 8, 2020
Closed
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 22, 2020

📝 Docs preview for commit a748ba1 at: https://5fba5d3f2c6b3e94a6fe348c--fastapi.netlify.app

@amitness
Copy link
Copy Markdown
Contributor Author

amitness commented Nov 22, 2020

@ycd I've fixed the merge conflicts. Can you look into it now?

@ycd
Copy link
Copy Markdown
Contributor

ycd commented Nov 22, 2020

Thanks, actually, you don't have to change the order, since your PR is older than the latest one, FYI.

@amitness
Copy link
Copy Markdown
Contributor Author

amitness commented Jan 11, 2021

@ycd I've no problems with the ordering. Let's merge it the way it is.

@tiangolo tiangolo changed the title Add "FastAPI for Flask Users" 📝 Add external link to "FastAPI for Flask Users" Feb 7, 2021
@tiangolo
Copy link
Copy Markdown
Member

tiangolo commented Feb 7, 2021

Thanks @amitness ! Great article! 👏 👏

And thanks @ycd for the help. 🙇 🍰

@tiangolo tiangolo merged commit 6b6a310 into fastapi:master Feb 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Kludex Kludex Kludex approved these changes

+2 more reviewers

@AdrianDeAnda AdrianDeAnda AdrianDeAnda approved these changes

@ycd ycd ycd approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@amitness @ycd @tiangolo @AdrianDeAnda @Kludex