Skip to content

Import root so that utilities have the CSS variables they need#37377

Merged
julien-deramond merged 4 commits intotwbs:mainfrom
ericleib:fix/bootstrap-utilities-variables
Oct 29, 2022
Merged

Import root so that utilities have the CSS variables they need#37377
julien-deramond merged 4 commits intotwbs:mainfrom
ericleib:fix/bootstrap-utilities-variables

Conversation

@ericleib
Copy link
Copy Markdown
Contributor

Description

Import root so that utilities have the CSS variables they need

Motivation & Context

This fixes #37376 (bootstrap-utilities.css missing required CSS variables)

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

@ericleib ericleib requested a review from a team as a code owner October 25, 2022 10:13
Copy link
Copy Markdown
Member

@mdo mdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call, thanks! Not sure how we missed that earlier hah.

@julien-deramond julien-deramond self-requested a review October 29, 2022 07:02
Copy link
Copy Markdown
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch @ericleib

@julien-deramond julien-deramond merged commit 60b0204 into twbs:main Oct 29, 2022
julien-deramond pushed a commit that referenced this pull request Nov 19, 2022
XhmikosR pushed a commit that referenced this pull request Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bootstrap-utilities.css missing CSS variables

3 participants