Skip to content

Fix deprecation warning with sass 1.56.0#37425

Merged
julien-deramond merged 1 commit intotwbs:mainfrom
blankse:patch-1
Nov 4, 2022
Merged

Fix deprecation warning with sass 1.56.0#37425
julien-deramond merged 1 commit intotwbs:mainfrom
blankse:patch-1

Conversation

@blankse
Copy link
Copy Markdown
Contributor

@blankse blankse commented Nov 4, 2022 •
edited by julien-deramond
Loading

Closes #37424

Description

With the new sass version 1.56.0 (https://github.com/sass/dart-sass/releases/tag/1.56.0) I get following deprecation warning:

Deprecation $weight: Passing a number without unit % (100) is deprecated.

To preserve current behavior: $weight * 1%

More info: https://sass-lang.com/d/function-units

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

@blankse blankse requested a review from a team as a code owner November 4, 2022 11:14
julien-deramond
julien-deramond approved these changes Nov 4, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @blankse. We haven't bumped the dependency yet but it's gonna be useful when we'll do it :)

@WilliamStam WilliamStam mentioned this pull request Nov 4, 2022
Closed
3 tasks
@julien-deramond julien-deramond merged commit 2b21094 into twbs:main Nov 4, 2022
@blankse blankse deleted the patch-1 branch November 4, 2022 18:48
@jakeboone02 jakeboone02 mentioned this pull request Nov 4, 2022
Closed
3 tasks
SamBrishes added a commit to RatMD/newshub-theme that referenced this pull request Nov 6, 2022
@SamBrishes
[FIX] TypeScript Typings + Fix SASS version number, see twbs/bootstra…
fe30725 
…p#37425
@rjd22 rjd22 mentioned this pull request Nov 10, 2022
Closed
@oguilleux oguilleux mentioned this pull request Nov 10, 2022
Closed
julien-deramond pushed a commit that referenced this pull request Nov 16, 2022
@blankse @julien-deramond
Fix deprecation warning with sass 1.56.0 (#37425)
5d02533 
Deprecation Warning: $weight: Passing a number without unit % (100) is deprecated.
To preserve current behavior: $weight * 1%
More info: https://sass-lang.com/d/function-units
@AndriiTereshchuk
Copy link
Copy Markdown

AndriiTereshchuk commented Nov 21, 2022 •
edited
Loading

Deprecation Warning: $weight: Passing a number without unit % (100) is deprecated.

To preserve current behavior: $weight * 1%

More info: https://sass-lang.com/d/function-units

╷

201 │ @return mix(rgba($foreground, 1), $background, opacity($foreground) * 100);
│ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
╵
node_modules/bootstrap/scss/_functions.scss 201:11 opaque()
node_modules/bootstrap/scss/mixins/_table-variants.scss 4:28 table-variant()
node_modules/bootstrap/scss/_tables.scss 147:3 @import
node_modules/bootstrap/scss/bootstrap.scss 20:9 @import
resources/sass/app.scss 5:9 root stylesheet

XhmikosR pushed a commit that referenced this pull request Nov 21, 2022
@blankse @XhmikosR
Fix deprecation warning with sass 1.56.0 (#37425)
b722369 
Deprecation Warning: $weight: Passing a number without unit % (100) is deprecated.
To preserve current behavior: $weight * 1%
More info: https://sass-lang.com/d/function-units
@Janatbek
Copy link
Copy Markdown

Janatbek commented Jan 6, 2023

I have sass 1.57.1, still getting same warning

@julien-deramond
Copy link
Copy Markdown
Member

julien-deramond commented Jan 6, 2023

Hey @Janatbek, if so please create a new issue with all the versions used to reproduce the problem.

@blankse
Copy link
Copy Markdown
Contributor Author

blankse commented Jan 6, 2023

@Janatbek Which bootstrap version do you use? This bugfix is only included in the current version v5.2.3

@moltar
Copy link
Copy Markdown

moltar commented Jan 8, 2023

I'm on 5.2.3 and I am still seeing this issue.

Deprecation Warning: $weight: Passing a number without unit % (80) is deprecated.

To preserve current behavior: $weight * 1%

More info: https://sass-lang.com/d/function-units

    ╷
207 │   @return mix(white, $color, $weight);
    │           ^^^^^^^^^^^^^^^^^^^^^^^^^^^
    ╵
    node_modules/bootstrap/scss/_functions.scss 207:11      tint-color()
    src/website/web/src/theme/variables/palette.scss 26:15  @import
    src/website/web/src/theme/variables/index.scss 1:9      @import
    src/website/web/src/theme/theme.module.scss 7:9         @import
    src/website/web/src/theme/index.scss 3:9                root stylesheet

❯ npm ls bootstrap
[email protected]
└── [email protected]

    node_modules/bootstrap/scss/_functions.scss 207:11      tint-color()

⬇️

// scss-docs-start color-functions
// Tint a color: mix a color with white
@function tint-color($color, $weight) {
  @return mix(white, $color, $weight);
}

@moltar
Copy link
Copy Markdown

moltar commented Jan 8, 2023

Also, the notice on GH says:

The pull request first appeared in v5.3.0-alpha1

@XhmikosR
Copy link
Copy Markdown
Member

XhmikosR commented Jan 9, 2023

This was fixed in 5.2.3. If you are getting the warning, it's either your local modules or another part in your Sass.

https://github.com/twbs/bootstrap/actions/runs/3517040211/jobs/5894345876

@twbs twbs locked as resolved and limited conversation to collaborators Jan 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@julien-deramond julien-deramond julien-deramond approved these changes

Assignees

No one assigned

Labels

css release-highlight v5

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Incompatible with sass 1.56.0

6 participants

@blankse @AndriiTereshchuk @Janatbek @julien-deramond @moltar @XhmikosR