check all net upgrade conditions

shelhamer · shelhamer · commit effa9411ca27 · 2016-02-29T21:22:15.000-08:00
check all conditions all the time; V0 -&gt; V1 and V1 -&gt; V2 do not suffice.
diff --git a/src/caffe/util/upgrade_proto.cpp b/src/caffe/util/upgrade_proto.cpp
@@ -13,7 +13,8 @@
 namespace caffe {
 
 bool NetNeedsUpgrade(const NetParameter& net_param) {
-  return NetNeedsV0ToV1Upgrade(net_param) || NetNeedsV1ToV2Upgrade(net_param);
+  return NetNeedsV0ToV1Upgrade(net_param) || NetNeedsV1ToV2Upgrade(net_param)
+      || NetNeedsDataUpgrade(net_param) || NetNeedsInputUpgrade(net_param);
 }
 
 bool UpgradeNetAsNeeded(const string& param_file, NetParameter* param) {
diff --git a/tools/upgrade_net_proto_text.cpp b/tools/upgrade_net_proto_text.cpp
@@ -32,7 +32,6 @@ int main(int argc, char** argv) {
     return 2;
   }
   bool need_upgrade = NetNeedsUpgrade(net_param);
-  bool need_data_upgrade = NetNeedsDataUpgrade(net_param);
   bool success = true;
   if (need_upgrade) {
     success = UpgradeNetAsNeeded(input_filename, &net_param);
@@ -44,10 +43,6 @@ int main(int argc, char** argv) {
     LOG(ERROR) << "File already in latest proto format: " << input_filename;
   }
 
-  if (need_data_upgrade) {
-    UpgradeNetDataTransformation(&net_param);
-  }
-
   // Save new format prototxt.
   WriteProtoToTextFile(net_param, argv[2]);
 

Original file line number	Diff line number	Diff line change
`@@ -13,7 +13,8 @@`
`13`	`13`	`namespace caffe {`
`14`	`14`
`15`	`15`	`bool NetNeedsUpgrade(const NetParameter& net_param) {`
`16`		`- return NetNeedsV0ToV1Upgrade(net_param) \|\| NetNeedsV1ToV2Upgrade(net_param);`
	`16`	`+ return NetNeedsV0ToV1Upgrade(net_param) \|\| NetNeedsV1ToV2Upgrade(net_param)`
	`17`	`+ \|\| NetNeedsDataUpgrade(net_param) \|\| NetNeedsInputUpgrade(net_param);`
`17`	`18`	`}`
`18`	`19`
`19`	`20`	`bool UpgradeNetAsNeeded(const string& param_file, NetParameter* param) {`