fix: CI uses wrong NDK version + lint not installed

xaionaro@dx.center · xaionaro@dx.center · commit b285f0c52e3c · 2026-03-15T01:42:48.000Z
1. install-ndk: check for the specific NDK version (28.0.13004108),
   not just any NDK. CI had NDK 27.3 pre-installed which lacks
   EGL 1.5 PFNEGL* function pointer typedefs.

2. CI: set ANDROID_NDK_HOME after install so Makefile uses r28.

3. lint: auto-install golangci-lint if not found (CI doesn't have it
   pre-installed when not using golangci-lint-action).
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -42,7 +42,9 @@ jobs:
           go-version: "1.24"
 
       - name: Install Android NDK
-        run: make install-ndk
+        run: |
+          make install-ndk
+          echo "ANDROID_NDK_HOME=$ANDROID_HOME/ndk/28.0.13004108" >> "$GITHUB_ENV"
 
       - name: Cross-compile examples and ndkcli
         run: make check-examples
@@ -65,7 +67,9 @@ jobs:
           sudo udevadm trigger --name-match=kvm
 
       - name: Install Android NDK
-        run: make install-ndk
+        run: |
+          make install-ndk
+          echo "ANDROID_NDK_HOME=$ANDROID_HOME/ndk/28.0.13004108" >> "$GITHUB_ENV"
 
       - name: Run examples on emulator
         uses: reactivecircus/android-emulator-runner@v2
@@ -88,7 +92,9 @@ jobs:
           go-version: "1.24"
 
       - name: Install Android NDK
-        run: make install-ndk
+        run: |
+          make install-ndk
+          echo "ANDROID_NDK_HOME=$ANDROID_HOME/ndk/28.0.13004108" >> "$GITHUB_ENV"
 
       - name: Build release binaries
         run: make ndkcli-release
diff --git a/Makefile b/Makefile
@@ -105,6 +105,7 @@ check-no-capi:
 	@echo "OK: no capi imports in cmd/ or examples/"
 
 lint:
+	@which golangci-lint >/dev/null 2>&1 || { echo "Installing golangci-lint..."; go install github.com/golangci/golangci-lint/v2/cmd/golangci-lint@latest; }
 	golangci-lint run ./tools/...
 
 # Cross-compile all examples and ndkcli for Android arm64 to catch compile errors (requires NDK)
@@ -134,18 +135,19 @@ e2e-examples-test:
 e2e-audio:
 	./tests/e2e/run-audio-e2e.sh
 
-# Install Android NDK (for CI; no-op if already present)
+# Install Android NDK r28 (for CI; no-op if the correct version is present)
 ANDROID_NDK_VERSION ?= r28
 ANDROID_NDK_DIR_NAME ?= 28.0.13004108
+NDK_INSTALL_PATH := $(ANDROID_HOME)/ndk/$(ANDROID_NDK_DIR_NAME)
 install-ndk:
-	@if [ -d "$(NDK_PATH)" ]; then echo "NDK already at $(NDK_PATH)"; exit 0; fi; \
+	@if [ -d "$(NDK_INSTALL_PATH)" ]; then echo "NDK $(ANDROID_NDK_VERSION) already at $(NDK_INSTALL_PATH)"; exit 0; fi; \
 	echo "Installing Android NDK $(ANDROID_NDK_VERSION)..."; \
 	wget -q "https://dl.google.com/android/repository/android-ndk-$(ANDROID_NDK_VERSION)-linux.zip" -O /tmp/ndk.zip; \
 	unzip -q /tmp/ndk.zip -d /tmp/ndk-extract/; \
 	mkdir -p "$(ANDROID_HOME)/ndk"; \
-	mv /tmp/ndk-extract/android-ndk-* "$(ANDROID_HOME)/ndk/$(ANDROID_NDK_DIR_NAME)"; \
+	mv /tmp/ndk-extract/android-ndk-* "$(NDK_INSTALL_PATH)"; \
 	rm -f /tmp/ndk.zip; \
-	echo "NDK installed to $(ANDROID_HOME)/ndk/$(ANDROID_NDK_DIR_NAME)"
+	echo "NDK installed to $(NDK_INSTALL_PATH)"
 
 # Build ndkcli for Android arm64 (requires NDK)
 ndkcli:
