Updated weak event listener tests for v8 6.5 (NativeScript#5697)

vtrifonov · dtopuzov · commit a616dbb9bbe2 · 2018-04-18T16:57:26.000+03:00
* Updated weak event listener tests for v8 6.5

* added missing parentheses
diff --git a/tests/app/ui/core/weak-event-listener/weak-event-listener-tests.ts b/tests/app/ui/core/weak-event-listener/weak-event-listener-tests.ts
@@ -101,9 +101,13 @@ export function test_listenerDoesNotRetainTarget(done) {
     const sourceRef = getSourceAsWeakRef();
     const targetRef = getTargetAsWeakRef();
 
-    addWeakEventListener(sourceRef.get(), Observable.propertyChangeEvent, emptyHandler, targetRef.get());
+    // with the v8 6.5 the GC does not release WeakRefs so fast if you pass them to a method
+    // that's why we are making the call to the addWeakEventListener in a closure so that the WeakRef will be easier released
+    (function() {
+        addWeakEventListener(sourceRef.get(), Observable.propertyChangeEvent, emptyHandler, targetRef.get());
+    })();
     forceGC();
-    
+
     try {
         TKUnit.assert(!targetRef.get(), "Target should be released after GC");
         done(null);
@@ -117,7 +121,11 @@ export function test_listenerDoesNotRetainSource(done) {
     const sourceRef = getSourceAsWeakRef();
     const targetRef = getTargetAsWeakRef();
 
-    addWeakEventListener(sourceRef.get(), Observable.propertyChangeEvent, targetRef.get().onEvent, targetRef.get());
+    // with the v8 6.5 the GC does not release WeakRefs so fast if you pass them to a method
+    // that's why we are making the call to the addWeakEventListener in a closure so that the WeakRef will be easier released
+    (function() {
+        addWeakEventListener(sourceRef.get(), Observable.propertyChangeEvent, targetRef.get().onEvent, targetRef.get());
+    })();
     forceGC();
 
     try {
