refactor: Ensure to use change image tag instead hardcoded image#475
Merged
jayair merged 1 commit intoanomalyco:sstfrom Sep 18, 2020
Merged
refactor: Ensure to use change image tag instead hardcoded image#475jayair merged 1 commit intoanomalyco:sstfrom
change image tag instead hardcoded image#475jayair merged 1 commit intoanomalyco:sstfrom
Conversation
Contributor
|
Oh this is pretty cool. Thank you! I didn't know you could do that. Can we use it as |
Contributor
Author
|
Yes, absolutely. Also, if you would want to have additional space between this image and first paragraph word (eg Let me know how you would like me to adjust this PR |
Contributor
|
@preshetin Oh that would be really cool! If you can handle the space that would be much better. |
Contributor
|
Going to try this in a dev branch! |
Contributor
|
Works like a charm. Thanks @preshetin! |
jayair
added a commit
that referenced
this pull request
Oct 8, 2020
* Adding cdk chapter and updating IaC chapter * Adding chapter to using Serverless Framework with CDK * refactor: Ensure to use change image tag instead hardcoded image (#475) * Moving to Jekyll tag instead of image * Switching all chapters to Jekyll change tag * Adding chapter on creating SST app * Working on DynamoDB chapter * Adding chapter on connecting sls and sst * Adding chapters on Cognito * Change best practice chapters to use SST * Finishing sst code snippets * Working on best practices chapter * Fixing best parctices chapters * Change first section to use SST * Fixing old links * Editing chapters * Add comments for CDK code * Editing main guide * Editing best practices * Updating chapter commnets * Updating changelog Co-authored-by: Petr Reshetin <[email protected]> Co-authored-by: Frank <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey there. While making edits some time ago I noticed that the
CHANGEutility image is hardcoded. To improve the author experience, I refactored it to use Jekyl's plugin system.To find and replace throughout all files in
_chaptersfolder , you may want to run this command inside project dir:I didn't include the changes made by this command to make the code review simpler. However, feel free to run it yourself.
Hope this would add some value to this awesome guide.