BAEL-4394: simplified assert statements + fixed type

cristianrosu94 · cristianrosu94 · commit 1beaed657ae7 · 2020-08-17T23:45:43.000+03:00
diff --git a/core-java-modules/core-java-io-3/src/test/java/com/baeldung/linenumber/LineAtGivenNumberUnitTest.java b/core-java-modules/core-java-io-3/src/test/java/com/baeldung/linenumber/LineAtGivenNumberUnitTest.java
@@ -17,7 +17,7 @@
 
 import static org.junit.Assert.assertEquals;
 
-public class LineAtGivenNumberTest {
+public class LineAtGivenNumberUnitTest {
 
     private static final String FILE_PATH = "src/test/resources/linesInput.txt";
 
@@ -29,8 +29,7 @@ public void givenFile_whenUsingBufferedReader_thenExtractedLineIsCorrect() throw
             }
 
             String extractedLine = br.readLine();
-            String expectedLine = "Line 4";
-            assertEquals(expectedLine, extractedLine);
+            assertEquals("Line 4", extractedLine);
         }
     }
 
@@ -42,47 +41,42 @@ public void givenFile_whenUsingScanner_thenExtractedLineIsCorrect() throws IOExc
             }
 
             String extractedLine = scanner.nextLine();
-            String expectedLine = "Line 4";
-            assertEquals(expectedLine, extractedLine);
+            assertEquals("Line 4", extractedLine);
         }
     }
 
     @Test
     public void givenSmallFile_whenUsingFilesAPI_thenExtractedLineIsCorrect() throws IOException {
         String extractedLine = Files.readAllLines(Paths.get(FILE_PATH)).get(4);
-        String expectedLine = "Line 5";
 
-        assertEquals(expectedLine, extractedLine);
+        assertEquals("Line 5", extractedLine);
     }
 
     @Test
     public void givenLargeFile_whenUsingFilesAPI_thenExtractedLineIsCorrect() throws IOException {
         try (Stream<String> lines = Files.lines(Paths.get(FILE_PATH))) {
             String extractedLine = lines.skip(4).findFirst().get();
-            String expectedLine = "Line 5";
 
-            assertEquals(expectedLine, extractedLine);
+            assertEquals("Line 5", extractedLine);
         }
     }
 
     @Test
-    public void givenFile_whenUsingFIleUtils_thenExtractedLineIsCorrect() throws IOException {
+    public void givenFile_whenUsingFileUtils_thenExtractedLineIsCorrect() throws IOException {
         ClassLoader classLoader = getClass().getClassLoader();
         File file = new File(classLoader.getResource("linesInput.txt").getFile());
 
         List<String> lines = FileUtils.readLines(file, "UTF-8");
 
         String extractedLine = lines.get(0);
-        String expectedLine = "Line 1";
-        assertEquals(expectedLine, extractedLine);
+        assertEquals("Line 1", extractedLine);
     }
 
     @Test
     public void givenFile_whenUsingIOUtils_thenExtractedLineIsCorrect() throws IOException {
         String fileContent = IOUtils.toString(new FileInputStream(FILE_PATH), StandardCharsets.UTF_8);
 
         String extractedLine = fileContent.split(System.lineSeparator())[0];
-        String expectedLine = "Line 1";
-        assertEquals(expectedLine, extractedLine);
+        assertEquals("Line 1", extractedLine);
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -17,7 +17,7 @@`
`17`	`17`
`18`	`18`	`import static org.junit.Assert.assertEquals;`
`19`	`19`
`20`		`-public class LineAtGivenNumberTest {`
	`20`	`+public class LineAtGivenNumberUnitTest {`
`21`	`21`
`22`	`22`	`private static final String FILE_PATH = "src/test/resources/linesInput.txt";`
`23`	`23`
`@@ -29,8 +29,7 @@ public void givenFile_whenUsingBufferedReader_thenExtractedLineIsCorrect() throw`
`29`	`29`	`}`
`30`	`30`
`31`	`31`	`String extractedLine = br.readLine();`
`32`		`- String expectedLine = "Line 4";`
`33`		`- assertEquals(expectedLine, extractedLine);`
	`32`	`+ assertEquals("Line 4", extractedLine);`
`34`	`33`	`}`
`35`	`34`	`}`
`36`	`35`
`@@ -42,47 +41,42 @@ public void givenFile_whenUsingScanner_thenExtractedLineIsCorrect() throws IOExc`
`42`	`41`	`}`
`43`	`42`
`44`	`43`	`String extractedLine = scanner.nextLine();`
`45`		`- String expectedLine = "Line 4";`
`46`		`- assertEquals(expectedLine, extractedLine);`
	`44`	`+ assertEquals("Line 4", extractedLine);`
`47`	`45`	`}`
`48`	`46`	`}`
`49`	`47`
`50`	`48`	`@Test`
`51`	`49`	`public void givenSmallFile_whenUsingFilesAPI_thenExtractedLineIsCorrect() throws IOException {`
`52`	`50`	`String extractedLine = Files.readAllLines(Paths.get(FILE_PATH)).get(4);`
`53`		`- String expectedLine = "Line 5";`
`54`	`51`
`55`		`- assertEquals(expectedLine, extractedLine);`
	`52`	`+ assertEquals("Line 5", extractedLine);`
`56`	`53`	`}`
`57`	`54`
`58`	`55`	`@Test`
`59`	`56`	`public void givenLargeFile_whenUsingFilesAPI_thenExtractedLineIsCorrect() throws IOException {`
`60`	`57`	`try (Stream<String> lines = Files.lines(Paths.get(FILE_PATH))) {`
`61`	`58`	`String extractedLine = lines.skip(4).findFirst().get();`
`62`		`- String expectedLine = "Line 5";`
`63`	`59`
`64`		`- assertEquals(expectedLine, extractedLine);`
	`60`	`+ assertEquals("Line 5", extractedLine);`
`65`	`61`	`}`
`66`	`62`	`}`
`67`	`63`
`68`	`64`	`@Test`
`69`		`- public void givenFile_whenUsingFIleUtils_thenExtractedLineIsCorrect() throws IOException {`
	`65`	`+ public void givenFile_whenUsingFileUtils_thenExtractedLineIsCorrect() throws IOException {`
`70`	`66`	`ClassLoader classLoader = getClass().getClassLoader();`
`71`	`67`	`File file = new File(classLoader.getResource("linesInput.txt").getFile());`
`72`	`68`
`73`	`69`	`List<String> lines = FileUtils.readLines(file, "UTF-8");`
`74`	`70`
`75`	`71`	`String extractedLine = lines.get(0);`
`76`		`- String expectedLine = "Line 1";`
`77`		`- assertEquals(expectedLine, extractedLine);`
	`72`	`+ assertEquals("Line 1", extractedLine);`
`78`	`73`	`}`
`79`	`74`
`80`	`75`	`@Test`
`81`	`76`	`public void givenFile_whenUsingIOUtils_thenExtractedLineIsCorrect() throws IOException {`
`82`	`77`	`String fileContent = IOUtils.toString(new FileInputStream(FILE_PATH), StandardCharsets.UTF_8);`
`83`	`78`
`84`	`79`	`String extractedLine = fileContent.split(System.lineSeparator())[0];`
`85`		`- String expectedLine = "Line 1";`
`86`		`- assertEquals(expectedLine, extractedLine);`
	`80`	`+ assertEquals("Line 1", extractedLine);`
`87`	`81`	`}`
`88`	`82`	`}`