Skip to content

Commit 5d5605a

Browse files
committed
BAEL-4503 PR/article review feedback
1 parent 91dbd70 commit 5d5605a

2 files changed

Lines changed: 5 additions & 5 deletions

File tree

core-java-modules/core-java-lang-3/src/main/java/com/baeldung/constantspatterns/calculations/MathConstants.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,9 @@
22

33
public final class MathConstants {
44
public static final double PI = 3.14159265359;
5-
public static final double GOLDEN_RATIO = 1.6180;
6-
public static final double GRAVITATIONAL_ACCELERATION = 9.8;
7-
public static final double EULERS_NUMBER = 2.7182818284590452353602874713527;
5+
static final double GOLDEN_RATIO = 1.6180;
6+
static final double GRAVITATIONAL_ACCELERATION = 9.8;
7+
static final double EULERS_NUMBER = 2.7182818284590452353602874713527;
88

99
public enum Operation {
1010
ADD, SUBTRACT, DIVIDE, MULTIPLY

core-java-modules/core-java-lang-3/src/test/java/com/baeldung/constantspatterns/ConstantPatternUnitTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,15 +6,15 @@
66

77
public class ConstantPatternUnitTest {
88
@Test
9-
public void givenTwoNumbersAndAdd_whenCallingCalculatorOperatOneTwoNumbers_correctAnswerReturned() {
9+
public void givenTwoNumbersAndAdd_whenCallingCalculatorOperatOneTwoNumbers_thenCorrectAnswerReturned() {
1010
Calculator calculator = new Calculator();
1111
double expected = 4;
1212
double answer = calculator.operateOnTwoNumbers(2, 2, Calculator.Operation.ADD);
1313
assertEquals(expected, answer);
1414
}
1515

1616
@Test
17-
public void givenTwoNumbersAndAdd_whenCallingGeometryCalculatorOperatOneTwoNumbers_correctAnswerReturned() {
17+
public void givenTwoNumbersAndAdd_whenCallingGeometryCalculatorOperatOneTwoNumbers_thenCorrectAnswerReturned() {
1818
GeometryCalculator calculator = new GeometryCalculator();
1919
double expected = 4;
2020
double answer = calculator.operateOnTwoNumbers(2, 2, GeometryCalculator.Operation.ADD);

0 commit comments

Comments
 (0)