[BAEL-15319] - Check modules that don't use our standard parents

amit2103 · amit2103 · commit 8510c6172485 · 2019-07-10T12:16:50.000+05:30
diff --git a/apache-olingo/olingo2/pom.xml b/apache-olingo/olingo2/pom.xml
@@ -9,12 +9,12 @@
 	<name>olingo2-sample</name>
 	<description>Sample Olingo 2 Project</description>
 
-	<parent>
-		<groupId>org.springframework.boot</groupId>
-		<artifactId>spring-boot-starter-parent</artifactId>
-		<version>2.1.3.RELEASE</version>
-		<relativePath /> <!-- lookup parent from repository -->
-	</parent>
+    <parent>
+        <artifactId>parent-boot-2</artifactId>
+        <groupId>com.baeldung</groupId>
+        <version>0.0.1-SNAPSHOT</version>
+        <relativePath>../../parent-boot-2</relativePath>
+    </parent>
 
 	<dependencies>
 		<dependency>
diff --git a/apache-olingo/olingo2/src/test/java/org/baeldung/examples/olingo2/Olingo2SampleApplicationUnitTest.java b/apache-olingo/olingo2/src/test/java/org/baeldung/examples/olingo2/Olingo2SampleApplicationUnitTest.java
@@ -7,7 +7,7 @@
 
 @RunWith(SpringRunner.class)
 @SpringBootTest
-public class Olingo2SampleApplicationTests {
+public class Olingo2SampleApplicationUnitTest {
 
 	@Test
 	public void contextLoads() {
diff --git a/apache-pulsar/pom.xml b/apache-pulsar/pom.xml
@@ -7,6 +7,13 @@
     <version>0.0.1</version>
     <name>apache-pulsar</name>
 
+    <parent>
+        <groupId>com.baeldung</groupId>
+        <artifactId>parent-modules</artifactId>
+        <version>1.0.0-SNAPSHOT</version>
+        <relativePath>..</relativePath>
+    </parent>
+
     <dependencies>
         <dependency>
             <groupId>org.apache.pulsar</groupId>
diff --git a/apache-pulsar/src/main/java/com/baeldung/ConsumerUnitTest.java b/apache-pulsar/src/main/java/com/baeldung/ConsumerUnitTest.java
@@ -7,7 +7,7 @@
 import org.apache.pulsar.client.api.PulsarClient;
 import org.apache.pulsar.client.api.SubscriptionType;
 
-public class ConsumerTest {
+public class ConsumerUnitTest {
 
     private static final String SERVICE_URL = "pulsar://localhost:6650";
     private static final String TOPIC_NAME = "test-topic";
diff --git a/apache-pulsar/src/main/java/com/baeldung/ProducerUnitTest.java b/apache-pulsar/src/main/java/com/baeldung/ProducerUnitTest.java
@@ -11,7 +11,7 @@
 import java.io.IOException;
 import java.util.stream.IntStream;
 
-public class ProducerTest {
+public class ProducerUnitTest {
 
     private static final String SERVICE_URL = "pulsar://localhost:6650";
     private static final String TOPIC_NAME = "test-topic";
diff --git a/apache-pulsar/src/main/java/com/baeldung/subscriptions/ExclusiveSubscriptionUnitTest.java b/apache-pulsar/src/main/java/com/baeldung/subscriptions/ExclusiveSubscriptionUnitTest.java
@@ -10,7 +10,7 @@
 
 import java.util.stream.IntStream;
 
-public class ExclusiveSubscriptionTest {
+public class ExclusiveSubscriptionUnitTest {
     private static final String SERVICE_URL = "pulsar://localhost:6650";
     private static final String TOPIC_NAME = "test-topic";
     private static final String SUBSCRIPTION_NAME = "test-subscription";
diff --git a/apache-pulsar/src/main/java/com/baeldung/subscriptions/FailoverSubscriptionUnitTest.java b/apache-pulsar/src/main/java/com/baeldung/subscriptions/FailoverSubscriptionUnitTest.java
@@ -11,7 +11,7 @@
 
 import java.util.stream.IntStream;
 
-public class FailoverSubscriptionTest {
+public class FailoverSubscriptionUnitTest {
     private static final String SERVICE_URL = "pulsar://localhost:6650";
     private static final String TOPIC_NAME = "failover-subscription-test-topic";
     private static final String SUBSCRIPTION_NAME = "test-subscription";
diff --git a/core-java-modules/multimodulemavenproject/daomodule/pom.xml b/core-java-modules/multimodulemavenproject/daomodule/pom.xml
@@ -1,15 +1,16 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
     <modelVersion>4.0.0</modelVersion>
+    <groupId>com.baeldung.daomodule</groupId>
+    <artifactId>daomodule</artifactId>
+    <version>1.0</version>
+    <packaging>jar</packaging>
+    
     <parent>
         <groupId>com.baeldung.multimodulemavenproject</groupId>
         <artifactId>multimodulemavenproject</artifactId>
         <version>1.0</version>
     </parent>
-    <groupId>com.baeldung.daomodule</groupId>
-    <artifactId>daomodule</artifactId>
-    <version>1.0</version>
-    <packaging>jar</packaging>
     
     <build>
         <plugins>
diff --git a/custom-pmd/pom.xml b/custom-pmd/pom.xml
@@ -7,6 +7,12 @@
     <name>custom-pmd</name>
     <packaging>jar</packaging>
     <url>http://maven.apache.org</url>
+    
+    <parent>
+        <artifactId>parent-modules</artifactId>
+        <groupId>com.baeldung</groupId>
+        <version>1.0.0-SNAPSHOT</version>
+    </parent>
 
     <dependencies>
         <dependency>
diff --git a/flyway-cdi-extension/pom.xml b/flyway-cdi-extension/pom.xml
@@ -8,6 +8,13 @@
     <version>1.0-SNAPSHOT</version>
     <name>flyway-cdi-extension</name>
 
+    <parent>
+        <groupId>com.baeldung</groupId>
+        <artifactId>parent-modules</artifactId>
+        <version>1.0.0-SNAPSHOT</version>
+        <relativePath>..</relativePath>
+    </parent>
+
     <dependencies>
         <dependency>
             <groupId>javax.enterprise</groupId>
diff --git a/kotlin-quasar/pom.xml b/kotlin-quasar/pom.xml
@@ -8,6 +8,12 @@
     <name>kotlin-quasar</name>
     <packaging>jar</packaging>
 
+    <parent>
+        <artifactId>parent-modules</artifactId>
+        <groupId>com.baeldung</groupId>
+        <version>1.0.0-SNAPSHOT</version>
+    </parent>
+
     <dependencies>
         <dependency>
             <groupId>org.jetbrains.kotlin</groupId>
diff --git a/maven-polyglot/maven-polyglot-json-app/pom.json b/maven-polyglot/maven-polyglot-json-app/pom.json
@@ -5,10 +5,10 @@
   "version": "1.0-SNAPSHOT",
   "name": "Json Maven Polyglot",
   "parent": {
-    "groupId": "org.springframework.boot",
-    "artifactId": "spring-boot-starter-parent",
-    "version": "2.0.5.RELEASE",
-    "relativePath": null
+    "groupId": "com.baeldung",
+    "artifactId": "parent-boot-2",
+    "version": "0.0.1-SNAPSHOT",
+    "relativePath": "../../parent-boot-2"
   },
   "properties": {
     "project.build.sourceEncoding": "UTF-8",
diff --git a/maven-polyglot/maven-polyglot-json-extension/pom.xml b/maven-polyglot/maven-polyglot-json-extension/pom.xml
@@ -8,17 +8,24 @@
     <version>1.0-SNAPSHOT</version>
 	<name>maven-polyglot-json-extension</name>
 
+    <parent>
+        <groupId>com.baeldung</groupId>
+        <artifactId>parent-modules</artifactId>
+        <version>1.0.0-SNAPSHOT</version>
+        <relativePath>../..</relativePath>
+    </parent>
+
     <dependencies>
         <dependency>
             <groupId>org.apache.maven</groupId>
             <artifactId>maven-core</artifactId>
-            <version>3.5.4</version>
+            <version>${maven-core.version}</version>
             <scope>provided</scope>
         </dependency>
         <dependency>
             <groupId>com.fasterxml.jackson.core</groupId>
             <artifactId>jackson-databind</artifactId>
-            <version>2.9.6</version>
+            <version>${jackson.version}</version>
         </dependency>
     </dependencies>
 
@@ -42,6 +49,7 @@
     <properties>
         <maven.compiler.source>1.8</maven.compiler.source>
         <maven.compiler.target>1.8</maven.compiler.target>
+        <maven-core.version>3.5.4</maven-core.version>
     </properties>
 
 </project>
diff --git a/maven-polyglot/maven-polyglot-yml-app/pom.yml b/maven-polyglot/maven-polyglot-yml-app/pom.yml
@@ -4,4 +4,10 @@ artifactId: maven-polyglot-yml-app
 version: 1.0-SNAPSHOT
 name: 'YAML Demo'
 
+parent: 
+  groupId: "com.baeldung"
+  artifactId: "parent-modules"
+  version: "1.0.0-SNAPSHOT"
+  relativePath: "../.."
+
 properties: {maven.compiler.source: 1.8, maven.compiler.target: 1.8}
diff --git a/maven/pom.xml b/maven/pom.xml
@@ -7,6 +7,12 @@
     <name>maven</name>
     <packaging>pom</packaging>
 
+    <parent>
+        <artifactId>parent-modules</artifactId>
+        <groupId>com.baeldung</groupId>
+        <version>1.0.0-SNAPSHOT</version>
+    </parent>
+
     <modules>
         <module>custom-rule</module>
         <module>maven-enforcer</module>
diff --git a/spring-boot-mvc-birt/pom.xml b/spring-boot-mvc-birt/pom.xml
@@ -9,11 +9,12 @@
     <version>0.0.1-SNAPSHOT</version>
     <packaging>jar</packaging>
     <description>Module For Spring Boot Integration with BIRT</description>
-	
+
     <parent>
-        <groupId>org.springframework.boot</groupId>
-        <artifactId>spring-boot-starter-parent</artifactId>
-        <version>2.1.1.RELEASE</version>
+        <artifactId>parent-boot-2</artifactId>
+        <groupId>com.baeldung</groupId>
+        <version>0.0.1-SNAPSHOT</version>
+        <relativePath>../parent-boot-2</relativePath>
     </parent>
 
     <dependencies>
diff --git a/testing-modules/easymock/pom.xml b/testing-modules/easymock/pom.xml
@@ -4,23 +4,27 @@
     xmlns="http://maven.apache.org/POM/4.0.0"
     xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
     <modelVersion>4.0.0</modelVersion>
+    <artifactId>easymock</artifactId>
+    <name>easymock</name>
+    <url>http://maven.apache.org</url>
+
     <parent>
         <groupId>com.baeldung</groupId>
         <artifactId>testing-modules</artifactId>
         <version>1.0.0-SNAPSHOT</version>
     </parent>
-    <artifactId>easymock</artifactId>
-    <name>easymock</name>
-    <url>http://maven.apache.org</url>
-    <properties>
-        <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
-    </properties>
+
     <dependencies>
         <dependency>
             <groupId>org.easymock</groupId>
             <artifactId>easymock</artifactId>
-            <version>4.0.2</version>
+            <version>${easymock.version}</version>
             <scope>test</scope>
         </dependency>
     </dependencies>
+
+    <properties>
+        <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
+        <easymock.version>4.0.2</easymock.version>
+    </properties>
 </project>
