BAEL-4504: Add finally

dstr89 · dstr89 · commit a247ca8ec2d8 · 2020-10-15T16:59:16.000+02:00
diff --git a/core-java-modules/core-java-networking-3/src/test/java/com/baeldung/socket/FindFreePortUnitTest.java b/core-java-modules/core-java-networking-3/src/test/java/com/baeldung/socket/FindFreePortUnitTest.java
@@ -85,61 +85,65 @@ public void givenAvailableTcpPort_whenCreatingServerSocket_thenThatPortIsAssigne
     }
 
     @Test
-    public void givenNoPortDefined_whenCreatingJettyServer_thenFreePortIsAssigned() {
+    public void givenNoPortDefined_whenCreatingJettyServer_thenFreePortIsAssigned() throws Exception {
         Server jettyServer = new Server();
         ServerConnector serverConnector = new ServerConnector(jettyServer);
         jettyServer.addConnector(serverConnector);
         try {
             jettyServer.start();
             assertThat(serverConnector.getLocalPort()).isGreaterThan(0);
-            jettyServer.stop();
-            jettyServer.destroy();
         } catch (Exception e) {
             fail("Failed to start Jetty server");
+        } finally {
+            jettyServer.stop();
+            jettyServer.destroy();
         }
     }
 
     @Test
-    public void givenExplicitFreePort_whenCreatingJettyServer_thenThatPortIsAssigned() {
+    public void givenExplicitFreePort_whenCreatingJettyServer_thenThatPortIsAssigned() throws Exception {
         Server jettyServer = new Server();
         ServerConnector serverConnector = new ServerConnector(jettyServer);
         serverConnector.setPort(FREE_PORT_NUMBER);
         jettyServer.addConnector(serverConnector);
         try {
             jettyServer.start();
             assertThat(serverConnector.getLocalPort()).isEqualTo(FREE_PORT_NUMBER);
-            jettyServer.stop();
-            jettyServer.destroy();
         } catch (Exception e) {
             fail("Failed to start Jetty server");
+        } finally {
+            jettyServer.stop();
+            jettyServer.destroy();
         }
     }
 
     @Test
-    public void givenPortZero_whenCreatingTomcatServer_thenFreePortIsAssigned() {
+    public void givenPortZero_whenCreatingTomcatServer_thenFreePortIsAssigned() throws Exception {
         Tomcat tomcatServer = new Tomcat();
         tomcatServer.setPort(0);
         try {
             tomcatServer.start();
             assertThat(tomcatServer.getConnector().getLocalPort()).isGreaterThan(0);
-            tomcatServer.stop();
-            tomcatServer.destroy();
         } catch (LifecycleException e) {
             fail("Failed to start Tomcat server");
+        } finally {
+            tomcatServer.stop();
+            tomcatServer.destroy();
         }
     }
 
     @Test
-    public void givenExplicitFreePort_whenCreatingTomcatServer_thenThatPortIsAssigned() {
+    public void givenExplicitFreePort_whenCreatingTomcatServer_thenThatPortIsAssigned() throws Exception {
         Tomcat tomcatServer = new Tomcat();
         tomcatServer.setPort(FREE_PORT_NUMBER);
         try {
             tomcatServer.start();
             assertThat(tomcatServer.getConnector().getLocalPort()).isEqualTo(FREE_PORT_NUMBER);
-            tomcatServer.stop();
-            tomcatServer.destroy();
         } catch (LifecycleException e) {
             fail("Failed to start Tomcat server");
+        } finally {
+            tomcatServer.stop();
+            tomcatServer.destroy();
         }
     }
 
