[BAEL-3981] Fixes from Josh's review

dupirefr · dupirefr · commit bb1ccffcaf5a · 2020-05-20T23:41:13.000+02:00
* Upgraded Apache Commons to 3.10

* Replaced Nathalie by Natalie
diff --git a/core-java-modules/core-java-lang-2/pom.xml b/core-java-modules/core-java-lang-2/pom.xml
@@ -70,7 +70,7 @@
         <jmh-generator.version>1.19</jmh-generator.version>
         <assertj.version>3.12.2</assertj.version>
         <commons.beanutils.version>1.9.4</commons.beanutils.version>
-        <commons-lang3.version>3.9</commons-lang3.version>
+        <commons-lang3.version>3.10</commons-lang3.version>
         <guava.version>29.0-jre</guava.version>
     </properties>
 
diff --git a/core-java-modules/core-java-lang-2/src/test/java/com/baeldung/comparing/EqualsMethodUnitTest.java b/core-java-modules/core-java-lang-2/src/test/java/com/baeldung/comparing/EqualsMethodUnitTest.java
@@ -66,8 +66,8 @@ void givenTwoPersonWithEqualsWithSameNames_whenEquals_thenTrue() {
     @Test
     void givenTwoPersonWittEqualsWithDifferentNames_whenEquals_thenFalse() {
         PersonWithEquals joe = new PersonWithEquals("Joe", "Portman");
-        PersonWithEquals nathalie = new PersonWithEquals("Nathalie", "Portman");
+        PersonWithEquals natalie = new PersonWithEquals("Natalie", "Portman");
 
-        assertThat(joe.equals(nathalie)).isFalse();
+        assertThat(joe.equals(natalie)).isFalse();
     }
 }
diff --git a/core-java-modules/core-java-lang-2/src/test/java/com/baeldung/comparing/GuavaUnitTest.java b/core-java-modules/core-java-lang-2/src/test/java/com/baeldung/comparing/GuavaUnitTest.java
@@ -58,13 +58,13 @@ void givenTwoIntsWithConsecutiveValues_whenIntsCompareMethodsReversed_thenNegati
     @Nested
     class ComparisonChainClass {
         @Test
-        void givenTwoPersonWithEquals_whenComparisonChainByLastNameThenFirstName_thenSortedJoeFirstAndNathalieSecond() {
-            PersonWithEquals nathalie = new PersonWithEquals("Nathalie", "Portman");
+        void givenTwoPersonWithEquals_whenComparisonChainByLastNameThenFirstName_thenSortedJoeFirstAndNatalieSecond() {
+            PersonWithEquals natalie = new PersonWithEquals("Natalie", "Portman");
             PersonWithEquals joe = new PersonWithEquals("Joe", "Portman");
 
             int comparisonResult = ComparisonChain.start()
-              .compare(nathalie.lastName(), joe.lastName())
-              .compare(nathalie.firstName(), joe.firstName())
+              .compare(natalie.lastName(), joe.lastName())
+              .compare(natalie.firstName(), joe.firstName())
               .result();
 
             assertThat(comparisonResult).isPositive();
diff --git a/core-java-modules/core-java-lang-2/src/test/java/com/baeldung/comparing/ObjectsEqualsStaticMethodUnitTest.java b/core-java-modules/core-java-lang-2/src/test/java/com/baeldung/comparing/ObjectsEqualsStaticMethodUnitTest.java
@@ -19,9 +19,9 @@ void givenTwoPersonWithEqualsWithSameNames_whenObjectsEquals_thenTrue() {
     @Test
     void givenTwoPersonWithEqualsWithDifferentNames_whenObjectsEquals_thenFalse() {
         PersonWithEquals joe = new PersonWithEquals("Joe", "Portman");
-        PersonWithEquals nathalie = new PersonWithEquals("Nathalie", "Portman");
+        PersonWithEquals natalie = new PersonWithEquals("Natalie", "Portman");
 
-        assertThat(Objects.equals(joe, nathalie)).isFalse();
+        assertThat(Objects.equals(joe, natalie)).isFalse();
     }
 
     @Test

Original file line number	Diff line number	Diff line change
`@@ -66,8 +66,8 @@ void givenTwoPersonWithEqualsWithSameNames_whenEquals_thenTrue() {`
`66`	`66`	`@Test`
`67`	`67`	`void givenTwoPersonWittEqualsWithDifferentNames_whenEquals_thenFalse() {`
`68`	`68`	`PersonWithEquals joe = new PersonWithEquals("Joe", "Portman");`
`69`		`- PersonWithEquals nathalie = new PersonWithEquals("Nathalie", "Portman");`
	`69`	`+ PersonWithEquals natalie = new PersonWithEquals("Natalie", "Portman");`
`70`	`70`
`71`		`- assertThat(joe.equals(nathalie)).isFalse();`
	`71`	`+ assertThat(joe.equals(natalie)).isFalse();`
`72`	`72`	`}`
`73`	`73`	`}`