Changes for Code review feedback:

akash-pandey · akash-pandey · commit ca681a8e67cf · 2018-12-02T10:44:27.000+05:30
1. Change main method to use command-line input.
2. Update test class to use static imports.
2. Add more use cases in test-cases.
diff --git a/algorithms-miscellaneous-1/src/main/java/com/baeldung/algorithms/string/LongestSubstringNonRepeatingCharacters.java b/algorithms-miscellaneous-1/src/main/java/com/baeldung/algorithms/string/LongestSubstringNonRepeatingCharacters.java
@@ -44,8 +44,11 @@ public static String getUniqueCharacterSubstring(String input) {
     }
 
     public static void main(String[] args) {
-        String input = "CODINGISAWESOME";
-        System.out.println(getUniqueCharacterSubstring(input));
+        if(args.length > 0) {
+            System.out.println(getUniqueCharacterSubstring(args[0]));
+        } else {
+            System.err.println("This program expects command-line input. Please try again!");
+        }
     }
 
 }
diff --git a/algorithms-miscellaneous-1/src/test/java/com/baeldung/algorithms/string/LongestSubstringNonRepeatingCharactersTest.java b/algorithms-miscellaneous-1/src/test/java/com/baeldung/algorithms/string/LongestSubstringNonRepeatingCharactersTest.java
@@ -1,20 +1,31 @@
 package com.baeldung.algorithms.string;
 
-import org.junit.jupiter.api.Assertions;
 import org.junit.jupiter.api.Test;
 
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static com.baeldung.algorithms.string.LongestSubstringNonRepeatingCharacters.getUniqueCharacterSubstring;
+import static com.baeldung.algorithms.string.LongestSubstringNonRepeatingCharacters.getUniqueCharacterSubstringBruteForce;
+
 public class LongestSubstringNonRepeatingCharactersTest {
 
     @Test
     void givenString_whenGetUniqueCharacterSubstringBruteForceCalled_thenResultFoundAsExpected() {
-        String input = "CODINGISAWESOME";
-        Assertions.assertEquals("NGISAWE", LongestSubstringNonRepeatingCharacters.getUniqueCharacterSubstringBruteForce(input));
+        assertEquals("", getUniqueCharacterSubstringBruteForce(""));
+        assertEquals("A", getUniqueCharacterSubstringBruteForce("A"));
+        assertEquals("ABCDEF", getUniqueCharacterSubstringBruteForce("AABCDEF"));
+        assertEquals("ABCDEF", getUniqueCharacterSubstringBruteForce("ABCDEFF"));
+        assertEquals("NGISAWE", getUniqueCharacterSubstringBruteForce("CODINGISAWESOME"));
+        assertEquals("be coding", getUniqueCharacterSubstringBruteForce("always be coding"));
     }
 
     @Test
     void givenString_whenGetUniqueCharacterSubstringCalled_thenResultFoundAsExpected() {
-        String input = "CODINGISAWESOME";
-        Assertions.assertEquals("NGISAWE",LongestSubstringNonRepeatingCharacters.getUniqueCharacterSubstring(input));
+        assertEquals("", getUniqueCharacterSubstring(""));
+        assertEquals("A", getUniqueCharacterSubstring("A"));
+        assertEquals("ABCDEF", getUniqueCharacterSubstring("AABCDEF"));
+        assertEquals("ABCDEF", getUniqueCharacterSubstring("ABCDEFF"));
+        assertEquals("NGISAWE", getUniqueCharacterSubstring("CODINGISAWESOME"));
+        assertEquals("be coding", getUniqueCharacterSubstring("always be coding"));
     }
 
 }

Original file line number	Diff line number	Diff line change
`@@ -44,8 +44,11 @@ public static String getUniqueCharacterSubstring(String input) {`
`44`	`44`	`}`
`45`	`45`
`46`	`46`	`public static void main(String[] args) {`
`47`		`- String input = "CODINGISAWESOME";`
`48`		`- System.out.println(getUniqueCharacterSubstring(input));`
	`47`	`+ if(args.length > 0) {`
	`48`	`+ System.out.println(getUniqueCharacterSubstring(args[0]));`
	`49`	`+ } else {`
	`50`	`+ System.err.println("This program expects command-line input. Please try again!");`
	`51`	`+ }`
`49`	`52`	`}`
`50`	`53`
`51`	`54`	`}`