Skip to content

Allow any expression with IncludeMembers#3424

Merged
jbogard merged 3 commits intomasterfrom
IncludeMembersAnyExpression
Jun 4, 2020
Merged

Allow any expression with IncludeMembers#3424
jbogard merged 3 commits intomasterfrom
IncludeMembersAnyExpression

Conversation

@lbargaoanu
Copy link
Copy Markdown
Contributor

@lbargaoanu lbargaoanu commented May 20, 2020 •
edited
Loading

The idea is to cache the included members. In a variable for Map and in a let clause for ProjectTo. I guess any expression doesn't necessarily sound like a good idea. We'll see :)

@lbargaoanu lbargaoanu added this to the v.next milestone May 20, 2020
@lbargaoanu lbargaoanu force-pushed the IncludeMembersAnyExpression branch 4 times, most recently from 390b3dd to e36222b Compare May 21, 2020 06:28
@lbargaoanu lbargaoanu marked this pull request as draft May 21, 2020 10:45
@lbargaoanu lbargaoanu force-pushed the IncludeMembersAnyExpression branch 3 times, most recently from 8fc53cb to a4ed2dc Compare May 21, 2020 13:07
@lbargaoanu lbargaoanu marked this pull request as ready for review May 21, 2020 13:08
@lbargaoanu lbargaoanu force-pushed the IncludeMembersAnyExpression branch 3 times, most recently from 7e7df3e to d8648b8 Compare May 22, 2020 08:26
@lbargaoanu lbargaoanu force-pushed the IncludeMembersAnyExpression branch from d8648b8 to 3952ef1 Compare May 22, 2020 09:04
@lbargaoanu lbargaoanu force-pushed the IncludeMembersAnyExpression branch 5 times, most recently from 703c7cf to 0e8a3f9 Compare May 27, 2020 13:29
@lbargaoanu lbargaoanu requested a review from jbogard May 28, 2020 06:29
@lbargaoanu lbargaoanu force-pushed the IncludeMembersAnyExpression branch 2 times, most recently from 6e3fb3a to 238b889 Compare May 29, 2020 03:49
@lbargaoanu
Copy link
Copy Markdown
Contributor Author

lbargaoanu commented Jun 3, 2020

@jbogard Review? :)

@lbargaoanu lbargaoanu force-pushed the IncludeMembersAnyExpression branch from 238b889 to a1175c3 Compare June 4, 2020 05:23
jbogard
jbogard approved these changes Jun 4, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@jbogard jbogard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need any additions to the docs?

@jbogard jbogard merged commit 51d6c29 into master Jun 4, 2020
@lbargaoanu
Copy link
Copy Markdown
Contributor Author

lbargaoanu commented Jun 4, 2020 •
edited
Loading

I don't think that restriction is mentioned anywhere. And for people already using it, it wouldn't be of much help. But I'll add smth if you think it's useful.

@lbargaoanu lbargaoanu deleted the IncludeMembersAnyExpression branch June 4, 2020 13:17
@github-actions
Copy link
Copy Markdown

github-actions bot commented Sep 17, 2020

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jbogard jbogard jbogard approved these changes

Assignees

@jbogard jbogard

Labels

Improvement

Projects

None yet

Milestone

10.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@lbargaoanu @jbogard