Global pre and postfixes#3518
Merged
jbogard merged 3 commits intoLuckyPennySoftware:masterfrom Oct 20, 2020
blemasle:global-pre-and-postfixes
Merged
Global pre and postfixes#3518jbogard merged 3 commits intoLuckyPennySoftware:masterfrom blemasle:global-pre-and-postfixes
jbogard merged 3 commits intoLuckyPennySoftware:masterfrom
blemasle:global-pre-and-postfixes
Conversation
lbargaoanu
approved these changes
Oct 16, 2020
Contributor
lbargaoanu
left a comment
There was a problem hiding this comment.
Thanks!
@jbogard Not sure how big of a breaking change, but it certainly makes sense.
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to these lines,
GlobalIgnores,SourceExtensionMethods,AllPropertyMapActionsandAllTypeMapActionsof a profile are all concatenated with the global configuration.PrefixesandPostfixesare not however, preventing the use of a global pre/postfixes definition.This PR changes
ProfileMapto allow such use cases. All tests are passing, but I'm not quite sure of implications regardingAddMemberConfigurationcalls inProfile.