add cleaner node:native request bodies when possible

ahmadnassri · ahmadnassri · commit 7d092776c664 · 2015-03-20T04:53:08.000-07:00
diff --git a/src/targets/node/native.js b/src/targets/node/native.js
@@ -30,10 +30,6 @@ module.exports = function (source, options) {
 
   code.push(util.format('var http = require("%s");', source.uriObj.protocol.replace(':', '')))
 
-  if (!source.postData.text && source.postData.params) {
-    code.push('var querystring = require("querystring");')
-  }
-
   code.blank()
       .push(util.format('var options = %s;', JSON.stringify(reqOpts, null, opts.indent)))
       .blank()
@@ -51,8 +47,24 @@ module.exports = function (source, options) {
       .push('});')
       .blank()
 
-  if (source.postData.text) {
-    code.push(util.format('req.write(%s);', JSON.stringify(source.postData.text)))
+  switch (source.postData.mimeType) {
+    case 'application/x-www-form-urlencoded':
+      if (source.postData.paramsObj) {
+        code.unshift('var qs = require("querystring");')
+        code.push(util.format('req.write(qs.stringify(%s));', util.inspect(source.postData.paramsObj)))
+      }
+      break
+
+    case 'application/json':
+      if (source.postData.jsonObj) {
+        code.push(util.format('req.write(JSON.stringify(%s));', util.inspect(source.postData.jsonObj)))
+      }
+      break
+
+    default:
+      if (source.postData.text) {
+        code.push(util.format('req.write(%s);', JSON.stringify(source.postData.text, null, opts.indent)))
+      }
   }
 
   code.push('req.end();')
diff --git a/test/fixtures/output/node/native/application-form-encoded.js b/test/fixtures/output/node/native/application-form-encoded.js
@@ -1,3 +1,4 @@
+var qs = require("querystring");
 var http = require("http");
 
 var options = {
@@ -23,5 +24,5 @@ var req = http.request(options, function (res) {
   });
 });
 
-req.write("foo=bar&hello=world");
+req.write(qs.stringify({ foo: 'bar', hello: 'world' }));
 req.end();
diff --git a/test/fixtures/output/node/native/application-json.js b/test/fixtures/output/node/native/application-json.js
@@ -23,5 +23,9 @@ var req = http.request(options, function (res) {
   });
 });
 
-req.write("{\"number\": 1, \"string\": \"f\\\"oo\", \"arr\": [1, 2, 3], \"nested\": {\"a\": \"b\"}, \"arr_mix\": [1, \"a\", {\"arr_mix_nested\": {}}] }");
+req.write(JSON.stringify({ number: 1,
+  string: 'f"oo',
+  arr: [ 1, 2, 3 ],
+  nested: { a: 'b' },
+  arr_mix: [ 1, 'a', { arr_mix_nested: {} } ] }));
 req.end();
diff --git a/test/fixtures/output/node/native/full.js b/test/fixtures/output/node/native/full.js
@@ -1,3 +1,4 @@
+var qs = require("querystring");
 var http = require("http");
 
 var options = {
@@ -25,5 +26,5 @@ var req = http.request(options, function (res) {
   });
 });
 
-req.write("foo=bar");
+req.write(qs.stringify({ foo: 'bar' }));
 req.end();
