fix getPathParameter determinism

tangiel · tangiel · commit 968f4204bc63 · 2018-02-16T12:09:09.000-08:00
getPathParameter was using a HashSet, when a LinkedHashSet preserves
the path ordering of the returned parameters.
diff --git a/endpoints-framework/src/main/java/com/google/api/server/spi/config/model/ApiMethodConfig.java b/endpoints-framework/src/main/java/com/google/api/server/spi/config/model/ApiMethodConfig.java
@@ -26,12 +26,11 @@
 import com.google.common.base.Preconditions;
 import com.google.common.collect.ImmutableList;
 import com.google.common.reflect.TypeToken;
-
 import java.lang.reflect.Method;
 import java.lang.reflect.Type;
 import java.util.ArrayList;
 import java.util.Collection;
-import java.util.HashSet;
+import java.util.LinkedHashSet;
 import java.util.List;
 import java.util.Map;
 import java.util.Objects;
@@ -499,7 +498,7 @@ public Collection<String> getPathParameters() {
     Pattern pathPattern = java.util.regex.Pattern.compile("\\{([^\\}]*)\\}");
     Matcher pathMatcher = pathPattern.matcher(path);
 
-    Collection<String> pathParameters = new HashSet<>();
+    Collection<String> pathParameters = new LinkedHashSet<>();
     while (pathMatcher.find()) {
       pathParameters.add(pathMatcher.group(1));
     }
