Add tests

BudjakovDmitry · BudjakovDmitry · commit fb4676646dff · 2025-02-27T13:18:18.000+03:00
diff --git a/homework_03/src/controller.py b/homework_03/src/controller.py
@@ -62,7 +62,6 @@ def _get_required_integer_field(cls, field: str) -> int:
             raise ValueError(f"Incorrect value for contact ID. It must be an integer")
         return int(value)
 
-
     def _add_contact(self):
         """Add contact to phonebook."""
         contact: Contact = self.phonebook.add_contact(
diff --git a/homework_03/tests/controller/test_controller.py b/homework_03/tests/controller/test_controller.py
@@ -1,21 +1,20 @@
-import builtins
 import os
 import random
-import unittest
+from unittest import TestCase
 from unittest.mock import call, patch
 
 from src.controller import PhonebookController, CommandNotFound, FieldRequired
-from src.model import Contact, JsonStorage
+from src.model import JsonStorage
 from src.view import Commands
 from tests.utils import (
+    generate_random_id,
     generate_random_string,
-    generate_random_phone,
     generate_contact,
     generate_contacts,
 )
 
 
-class TestControllerGetCommand(unittest.TestCase):
+class TestControllerGetCommand(TestCase):
     def setUp(self):
         self.controller = PhonebookController()
 
@@ -41,7 +40,7 @@ def test_empty_command(self):
             self.assertEqual(command, result)
 
 
-class TestGetRequiredField(unittest.TestCase):
+class TestGetRequiredField(TestCase):
     def setUp(self):
         self.controller = PhonebookController()
 
@@ -64,7 +63,7 @@ def test_empty_value(self):
             )
 
 
-class TestAddContact(unittest.TestCase):
+class TestAddContact(TestCase):
     def setUp(self):
         self.controller = PhonebookController()
 
@@ -110,7 +109,7 @@ def test_add_contact_output(self, output):
                 )
 
 
-class TestFindContact(unittest.TestCase):
+class TestFindContact(TestCase):
     def setUp(self):
         self.controller = PhonebookController()
 
@@ -152,7 +151,106 @@ def test_output_multiple_contacts(self, output):
                 self.controller._find_contact()
                 calls = [
                     call(contact_id=c.id, name=c.name, phone=c.phone, comment=c.comment)
-                    for c in contacts[1:]
+                    for c in contacts
                 ]
                 output.assert_has_calls(calls)
                 self.assertEqual(output.call_count, len(contacts))
+
+
+class TestGetRequiredIntegerField(TestCase):
+    def setUp(self):
+        self.controller = PhonebookController()
+
+    def tearDown(self):
+        if os.path.isfile(JsonStorage.STORAGE):
+            os.remove(JsonStorage.STORAGE)
+
+    @patch("src.view.InputView.ask_required_field")
+    def test_required_field_asked(self, view):
+        field = generate_random_string()
+        self.controller._get_required_integer_field(field=field)
+        view.assert_called_with(field)
+
+    def test_entered_integer_value(self):
+        expected = generate_random_id()
+        with patch("src.view.InputView.ask_required_field", return_value=str(expected)):
+            result = self.controller._get_required_integer_field(
+                generate_random_string()
+            )
+            self.assertEqual(result, expected)
+
+    def test_entered_not_integer_value(self):
+        with patch(
+            "src.view.InputView.ask_required_field",
+                return_value=generate_random_string()
+        ):
+            self.assertRaises(
+                ValueError,
+                self.controller._get_required_integer_field,
+                generate_random_id(),
+            )
+
+
+class TestEditContact(TestCase):
+    def setUp(self):
+        self.controller = PhonebookController()
+
+    def tearDown(self):
+        if os.path.isfile(JsonStorage.STORAGE):
+            os.remove(JsonStorage.STORAGE)
+
+    @patch("src.view.InputView.update_field", side_effect=["", "", ""])
+    @patch("src.model.PhonebookModel.get")
+    @patch("src.controller.PhonebookController._get_required_integer_field")
+    def test_contact_id_asked(self, ask_integer, phonebook_model, update_fields):
+        self.controller._edit_contact()
+        ask_integer.assert_called_with("ID")
+
+    @patch("src.view.InputView.update_field", side_effect=["", "", ""])
+    @patch("src.model.PhonebookModel.get")
+    def test_get_contact_called(self, get_contact, update_fields):
+        contact_id = generate_random_id()
+        with patch(
+            "src.controller.PhonebookController._get_required_integer_field",
+            return_value=contact_id
+        ):
+            self.controller._edit_contact()
+            get_contact.assert_called_with(contact_id)
+
+    # @patch("src.view.InputView.update_field")
+    @patch("src.model.PhonebookModel.get")
+    @patch("src.controller.PhonebookController._get_required_integer_field")
+    def test_new_name_asked(self, ask_id, get_contact):
+        with patch("src.view.InputView.update_field") as ask_new_values:
+            self.controller._edit_contact()
+            calls = [call("name"), call("phone"), call("comment")]
+            ask_new_values.assert_has_calls(calls, any_order=True)
+            self.assertEqual(3, ask_new_values.call_count)
+
+
+    def test_update_name_called(self):
+        pass
+
+    def test_try_clear_name(self):
+        pass
+
+    def test_new_phone_asked(self):
+        pass
+
+    def test_update_phone_called(self):
+        pass
+
+    def test_try_clear_phone(self):
+        pass
+
+    def test_new_comment_asked(self):
+        pass
+
+    def test_clear_comment_called(self):
+        pass
+
+    def test_update_comment_called(self):
+        pass
+
+    def test_return_contact(self):
+        pass
