Add support for SLES

buzzdeee · buzzdeee · commit 0b02ef75ea8c · 2015-06-19T11:31:10.000+02:00
Besides added Support, add specs for SLES, and update metadata.json
to reflect the support.
diff --git a/manifests/init.pp b/manifests/init.pp
@@ -84,7 +84,7 @@
   validate_bool($manage_gunicorn)
 
   # Module compatibility check
-  $compatible = [ 'Debian', 'RedHat']
+  $compatible = [ 'Debian', 'RedHat', 'Suse' ]
   if ! ($::osfamily in $compatible) {
     fail("Module is not compatible with ${::operatingsystem}")
   }
diff --git a/manifests/install.pp b/manifests/install.pp
@@ -23,7 +23,8 @@
 
   $pythondev = $::osfamily ? {
     'RedHat' => "${python}-devel",
-    'Debian' => "${python}-dev"
+    'Debian' => "${python}-dev",
+    'Suse'   => "${python}-devel"
   }
 
   # pip version: use only for installation via os package manager!
diff --git a/manifests/params.pp b/manifests/params.pp
@@ -13,5 +13,6 @@
   $valid_versions = $::osfamily ? {
     'RedHat' => ['3'],
     'Debian' => ['3', '3.3'],
+    'Suse'   => [],
   }
 }
diff --git a/metadata.json b/metadata.json
@@ -32,6 +32,12 @@
         "12.04",
         "14.04"
       ]
+    },
+    {
+      "operatingsystem": "SLES",
+      "operatingsystemrelease": [
+        "11.3"
+      ]
     }
   ],
   "requirements": [
diff --git a/spec/classes/python_spec.rb b/spec/classes/python_spec.rb
@@ -61,7 +61,7 @@
       
       # python::provider
       context "default" do
-        let (:params) {{ :provider => '' }} 
+        let (:params) {{ :provider => '' }}
         it { is_expected.to contain_package("python-virtualenv")}
         it { is_expected.to contain_package("python-pip")}
         
@@ -181,4 +181,94 @@
       end
     end
   end
-end 
+
+  context "on a SLES 11 SP3" do
+    let :facts do
+      {
+        :id => 'root',
+        :kernel => 'Linux',
+        :osfamily => 'Suse',
+        :operatingsystem => 'SLES',
+        :operatingsystemrelease => '11.3',
+        :concat_basedir => '/dne',
+        :path => '/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin',
+      }
+    end
+    it { is_expected.to contain_class("python::install") }
+    # Base Suse packages.
+    it { is_expected.to contain_package("python") }
+    it { is_expected.to contain_package("python-devel") }
+    it { is_expected.to contain_package("python-pip") }
+    # Basic python packages (from pip)
+    it { is_expected.to contain_package("python-virtualenv")}
+
+    describe "with python::dev" do
+      context "true" do
+        let (:params) {{ :dev => true }}
+        it { is_expected.to contain_package("python-devel").with_ensure('present') }
+      end
+      context "empty/default" do
+        it { is_expected.to contain_package("python-devel").with_ensure('absent') }
+      end
+    end
+
+    describe "with manage_gunicorn" do
+      context "true" do
+        let (:params) {{ :manage_gunicorn => true }}
+        it { is_expected.to contain_package("gunicorn") }
+      end
+      context "empty args" do
+        #let (:params) {{ :manage_gunicorn => '' }}
+        it { is_expected.to contain_package("gunicorn") }
+      end
+      context "false" do
+        let (:params) {{ :manage_gunicorn => false }}
+        it {is_expected.not_to contain_package("gunicorn")}
+      end
+    end
+
+    describe "with python::provider" do
+      context "pip" do
+        let (:params) {{ :provider => 'pip' }}
+
+        it { is_expected.to contain_package("virtualenv").with(
+          'provider' => 'pip'
+        )}
+        it { is_expected.to contain_package("pip").with(
+          'provider' => 'pip'
+        )}
+      end
+
+      # python::provider
+      context "default" do
+        let (:params) {{ :provider => '' }}
+        it { is_expected.to contain_package("python-virtualenv")}
+        it { is_expected.to contain_package("python-pip")}
+
+        describe "with python::virtualenv" do
+          context "true" do
+            let (:params) {{ :provider => '', :virtualenv => true }}
+            it { is_expected.to contain_package("python-virtualenv").with_ensure('present') }
+          end
+        end
+
+        describe "with python::virtualenv" do
+          context "default/empty" do
+            let (:params) {{ :provider => '' }}
+            it { is_expected.to contain_package("python-virtualenv").with_ensure('absent') }
+          end
+        end
+      end
+    end
+
+    describe "with python::dev" do
+      context "true" do
+        let (:params) {{ :dev => true }}
+        it { is_expected.to contain_package("python-devel").with_ensure('present') }
+      end
+      context "default/empty" do
+        it { is_expected.to contain_package("python-devel").with_ensure('absent') }
+      end
+    end
+  end
+end

Original file line number	Diff line number	Diff line change
`@@ -84,7 +84,7 @@`
`84`	`84`	`validate_bool($manage_gunicorn)`
`85`	`85`
`86`	`86`	`# Module compatibility check`
`87`		`- $compatible = [ 'Debian', 'RedHat']`
	`87`	`+ $compatible = [ 'Debian', 'RedHat', 'Suse' ]`
`88`	`88`	`if ! ($::osfamily in $compatible) {`
`89`	`89`	`fail("Module is not compatible with ${::operatingsystem}")`
`90`	`90`	`}`
Original file line number	Diff line number	Diff line change
`@@ -23,7 +23,8 @@`
`23`	`23`
`24`	`24`	`$pythondev = $::osfamily ? {`
`25`	`25`	`'RedHat' => "${python}-devel",`
`26`		`- 'Debian' => "${python}-dev"`
	`26`	`+ 'Debian' => "${python}-dev",`
	`27`	`+ 'Suse' => "${python}-devel"`
`27`	`28`	`}`
`28`	`29`
`29`	`30`	`# pip version: use only for installation via os package manager!`
Original file line number	Diff line number	Diff line change
`@@ -13,5 +13,6 @@`
`13`	`13`	`$valid_versions = $::osfamily ? {`
`14`	`14`	`'RedHat' => ['3'],`
`15`	`15`	`'Debian' => ['3', '3.3'],`
	`16`	`+ 'Suse' => [],`
`16`	`17`	`}`
`17`	`18`	`}`
Original file line number	Diff line number	Diff line change
`@@ -32,6 +32,12 @@`
`32`	`32`	`"12.04",`
`33`	`33`	`"14.04"`
`34`	`34`	`]`
	`35`	`+ },`
	`36`	`+ {`
	`37`	`+ "operatingsystem": "SLES",`
	`38`	`+ "operatingsystemrelease": [`
	`39`	`+ "11.3"`
	`40`	`+ ]`
`35`	`41`	`}`
`36`	`42`	`],`
`37`	`43`	`"requirements": [`