Feedback from Jeroen

Luciano Nooijen · Luciano Nooijen · commit cc8b1c207409 · 2018-12-06T20:38:24.000+01:00
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "nodejs-blog",
-  "version": "0.0.7",
+  "version": "0.0.8",
   "description": "A blog API built in NodeJS that can be used as a standalone application, or included in a NodeJS application",
   "main": "index.js",
   "author": "Luciano Nooijen <luciano@bytecode.nl> (https://bytecode.nl)",
@@ -31,9 +31,9 @@
     "lint": "yarn run lint:js && yarn run lint:ts",
     "lint:js": "eslint --ext .js,.jsx .",
     "lint:ts": "tslint --project .",
-    "test": "NODE_ENV=test jest -i",
+    "test": "NODE_ENV=test jest -i --forceExit",
     "test:watch": "NODE_ENV=test jest -i --watch",
-    "coverage": "NODE_ENV=test jest -i --coverage",
+    "coverage": "NODE_ENV=test jest -i --coverage --forceExit",
     "migrate": "knex migrate:latest",
     "reinstall": "rm -rf node_modules && yarn",
     "clean": "rm -rf dist build coverage"
diff --git a/tests/controllers/categories.test.ts b/tests/controllers/categories.test.ts
@@ -1,8 +1,6 @@
 import { useTestDatabase } from '../config/index';
 import blog from '../config/blog';
 
-const { authHelper } = require('../../helpers');
-
 const {
     listCategories,
     getCategory,
diff --git a/tests/helpers/auth-helper.test.ts b/tests/helpers/auth-helper.test.ts
@@ -46,10 +46,8 @@ describe('Authentication helper', () => {
     });
 
     test('decodeJWT should return the correct payload', () => {
-        const payload = authHelper.generatePayload(payloadData);
         const authToken = authHelper.generateJWT(payloadData);
         const decodedPayload = authHelper.decodeJWT(authToken);
-        // expect(decodedPayload).toEqual(payload); // Flaky
         expect(decodedPayload.data).toEqual(payloadData);
     });
 
diff --git a/tests/index.test.ts b/tests/index.test.ts
@@ -1,3 +1,5 @@
+import { useTestDatabase } from './config/index';
+
 const nodeBlog = require('../');
 const { authors, auth, users, categories, articles } = require('../');
 
@@ -8,9 +10,18 @@ const database = process.env.DB_NAME_TEST;
 const password = process.env.DB_PASS_TEST;
 const debug = process.env.KNEX_DEBUG === 'true';
 
-const nodeBlogArguments = { client, host, user, database, password, debug };
+const nodeBlogArguments = {
+    client,
+    host,
+    user,
+    database,
+    password,
+    debug,
+};
 const blog = nodeBlog(client, host, user, database, password, debug);
 
+useTestDatabase();
+
 describe('NodeBlog NPM module', () => {
     test('NodeBlog to create a knex instance', () => {
         expect(typeof blog).toBe('function');
