[camera] Fix unawaited future errors (flutter#2312)

Michael Klimushyn · web-flow · commit 948744e9ee7c · 2019-11-26T14:49:35.000-08:00
There's a over a dozen API surfaces that are undocumented still. This
just fixes one of the new pedantic lints.
diff --git a/packages/camera/CHANGELOG.md b/packages/camera/CHANGELOG.md
@@ -1,3 +1,7 @@
+## 0.5.7
+
+* Fix unawaited futures.
+
 ## 0.5.6+4
 
 * Android: Use CameraDevice.TEMPLATE_RECORD to improve image streaming.
diff --git a/packages/camera/analysis_options.yaml b/packages/camera/analysis_options.yaml
@@ -8,4 +8,3 @@ include: ../../analysis_options.yaml
 analyzer:
   errors:
     public_member_api_docs: ignore
-    unawaited_futures: ignore
diff --git a/packages/camera/example/lib/main.dart b/packages/camera/example/lib/main.dart
@@ -2,6 +2,8 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+// ignore_for_file: public_member_api_docs
+
 import 'dart:async';
 import 'dart:io';
 
diff --git a/packages/camera/example/test_driver/camera_e2e.dart b/packages/camera/example/test_driver/camera_e2e.dart
@@ -231,7 +231,7 @@ void main() {
       sleep(const Duration(milliseconds: 500));
 
       await controller.stopImageStream();
-      controller.dispose();
+      await controller.dispose();
     },
     skip: !Platform.isAndroid,
   );
diff --git a/packages/camera/example/test_driver/camera_e2e_test.dart b/packages/camera/example/test_driver/camera_e2e_test.dart
@@ -35,7 +35,7 @@ Future<void> main() async {
   final FlutterDriver driver = await FlutterDriver.connect();
   final String result =
       await driver.requestData(null, timeout: const Duration(minutes: 1));
-  driver.close();
+  await driver.close();
   print('Test finished. Revoking camera permissions...');
   Process.runSync('adb', <String>[
     'shell',
diff --git a/packages/camera/lib/camera.dart b/packages/camera/lib/camera.dart
@@ -445,7 +445,7 @@ class CameraController extends ValueNotifier<CameraValue> {
       throw CameraException(e.code, e.message);
     }
 
-    _imageStreamSubscription.cancel();
+    await _imageStreamSubscription.cancel();
     _imageStreamSubscription = null;
   }
 
diff --git a/packages/camera/pubspec.yaml b/packages/camera/pubspec.yaml
@@ -2,7 +2,7 @@ name: camera
 description: A Flutter plugin for getting information about and controlling the
   camera on Android and iOS. Supports previewing the camera feed, capturing images, capturing video,
   and streaming image buffers to dart.
-version: 0.5.6+3
+version: 0.5.7
 
 authors:
   - Flutter Team <flutter-dev@googlegroups.com>

Original file line number	Diff line number	Diff line change
`@@ -445,7 +445,7 @@ class CameraController extends ValueNotifier<CameraValue> {`
`445`	`445`	`throw CameraException(e.code, e.message);`
`446`	`446`	`}`
`447`	`447`
`448`		`- _imageStreamSubscription.cancel();`
	`448`	`+ await _imageStreamSubscription.cancel();`
`449`	`449`	`_imageStreamSubscription = null;`
`450`	`450`	`}`
`451`	`451`