Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: 734m/node-xml2json
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: Chrivera/node-xml2json
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 3 commits
  • 26 files changed
  • 1 contributor

Commits on Mar 19, 2013

  1. Added ( typeof(obj[key]) == number ) to include elements a JSON objec…

    …t, that were getting omitted.
    Christopher Rivera committed Mar 19, 2013
    Configuration menu
    Copy the full SHA
    1773327 View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2013

  1. merging in changes from master after 0.3.2 and my number change.

    Christopher Rivera committed Apr 3, 2013
    Configuration menu
    Copy the full SHA
    61d15d1 View commit details
    Browse the repository at this point in the history

Commits on May 21, 2013

  1. The main focus of this commit are changes to fix the handling of html…

    … entities. It looks like the conversion from JSON to XML fails to handle characters like " and & properly, so invalid XML is generated. I took the sanitize function from xml2json and reused it for json2xml conversion.
    
    bin/xml2json: adding file from original repo
    lib/json2xml: adding latest version and updating with my changes.
    lib/xml2json: adding latest version and referencing sanitize from external file.
    lib/sanitize.js: moving santize function and characters object to shared file.
    
    - adding sanitize option to toXml output when characters like &, ', " exists.
    - fixing issue in santiize function, where it replaces the first instance of the character to replace, to performing a global replace.
    - moving sanitize() code to a shared file.
    Christopher Rivera committed May 21, 2013
    Configuration menu
    Copy the full SHA
    165c5c1 View commit details
    Browse the repository at this point in the history
Loading