Skip to content
This repository was archived by the owner on Aug 17, 2024. It is now read-only.
This repository was archived by the owner on Aug 17, 2024. It is now read-only.

JS2 Week 1 exercise test issues #230

@illicitonion

Description

@illicitonion

Issues with JS2 Week1 exercise tests (in roughly descending order of priority):

  • Groceries is easily testable but currently has no tests
  • People I know - The tests compare with arrays and have assertions on the order of elements in the arrays, where there isn't an obvious natural order for the values. The values for "Friends with Stacie Villarreal" and "Find the email address" for instance are expected in the reverse order as they appear in the original object (but happen to be sorted), whereas the values for "Friends who can multitask" are expected to be in the order they're found in the object, which is not sorted. If we're not going to do a "smart" assertion here, I'd recommend we assert they're in the order they appear in the object.
  • Writers: None of the writers are under 40, so skipping the lower bound on the age range works. Also, none are on the boundary cases (40, 49).
  • Water bottle - we don't test pouring other than for a full or empty bottle. Would be handy to add a pour for a partially full bottle.

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions