Merge pull request voxpupuli#274 from rosenbergj/issue-273

Shiva Poudel · Shiva Poudel · commit 0d08d4e636cf · 2015-12-15T22:59:35.000+05:45
new manage_requirements argument to address issue 273
diff --git a/README.md b/README.md
@@ -128,6 +128,8 @@ Installs and manages Python packages from requirements file.
 
 **group** - The group that was used to create the virtualenv.  This is used to create the requirements file with correct permissions if it's not present already.
 
+**manage_requirements** - Create the requirements file if it doesn't exist. Default: true
+
 ```puppet
   python::requirements { '/var/www/project1/requirements.txt' :
     virtualenv => '/var/www/project1',
diff --git a/manifests/requirements.pp b/manifests/requirements.pp
@@ -38,6 +38,9 @@
 # [*extra_pip_args*]
 # Extra arguments to pass to pip after the requirements file
 #
+# [*manage_requirements*]
+# Create the requirements file if it doesn't exist. Default: true
+#
 # [*fix_requirements_owner*]
 # Change owner and group of requirements file. Default: true
 #
@@ -71,6 +74,7 @@
   $forceupdate            = false,
   $cwd                    = undef,
   $extra_pip_args         = '',
+  $manage_requirements    = true,
   $fix_requirements_owner = true,
   $log_dir                = '/tmp',
   $timeout                = 1800,
@@ -110,7 +114,7 @@
 
   # This will ensure multiple python::virtualenv definitions can share the
   # the same requirements file.
-  if !defined(File[$requirements]) {
+  if !defined(File[$requirements]) and $manage_requirements == true {
     file { $requirements:
       ensure  => present,
       mode    => '0644',
diff --git a/spec/defines/requirements_spec.rb b/spec/defines/requirements_spec.rb
@@ -21,6 +21,10 @@
         let (:params) {{ :requirements => "/requirements.txt" }}
         it { is_expected.to contain_file("/requirements.txt").with_mode('0644') }
       end
+      context "/requirements.txt" do
+        let (:params) {{ :requirements => "/requirements.txt", :manage_requirements => false }}
+        it { is_expected.not_to contain_file("/requirements.txt") }
+      end
 
       describe "with owner" do
         context "bob:bob" do
