TorQ_679: Support immediate writing in WDB

mchbrn-q · web-flow · commit a4aff2e1a0eb · 2024-11-13T16:50:34.000+08:00
The forcesave parameter disregards table count checks when .wdb.savetodisk is called on the timer. The .wdb.immediate argument has been added to configure this behaviour. Logic in .wdb.replayupd is unaffected by this configuration
diff --git a/code/processes/wdb.q b/code/processes/wdb.q
@@ -41,6 +41,7 @@ mergenumbytes:@[value;`mergenumbytes;500000000];                             /-d
 
 mergenumrows:@[value;`mergenumrows;100000];                                /-default number of rows for merge process
 mergenumtab:@[value;`mergenumtab;`quote`trade!10000 50000];                /-specify number of rows per table for merge process
+immediate:@[value;`immediate;0b];                                          /-disregards .wdb.maxrows and writes down data every time timer calls .wdb.savetodisk
 
 hdbtypes:@[value;`hdbtypes;`hdb];                                          /-list of hdb types to look for and call in hdb reload
 rdbtypes:@[value;`rdbtypes;`rdb];                                          /-list of rdb types to look for and call in rdb reload
@@ -166,7 +167,7 @@ savetablesbypart:{[dir;pt;forcesave;tablename;writedownmode]
 savetables:$[writedownmode in partwritemodes;savetablesbypart[;;;;writedownmode];savetables];
 
 savetodisk:{[]
-    changes:savetables[savedir;getpartition[];0b;] each tablelist[];
+    changes:savetables[savedir;getpartition[];immediate;] each tablelist[];
     /- we have to let the idbs know of the changes in the wdbhdb. using filldb[] to make sure it is a db with all the tables
     if[any[changes] and writedownmode in `partbyenum`default;filldb[];notifyidbs[`.idb.intradayreload;enlist()]]};
 
diff --git a/tests/wdb/replay/savetables_replay.csv b/tests/wdb/replay/savetables_replay.csv
@@ -0,0 +1,5 @@
+action,ms,bytes,lang,code,repeat,minver,comment
+before,0,0,q,update active:0b from `.timer.timer,,"Disable timer"
+before,0,0,q,.wdb.immediate:1b,,"Show that immediate write not used in .wdb.replayupd"
+true,0,0,q,(counts < .wdb.maxrows `quote) and (0 < counts:count quote),1,,"Show number of quotes played back from tplog are less than .wdb.maxrows[`quote]"
+true,0,0,q,delete quote from `.; system " " sv (enlist "l"; "/" sv ((getenv `KDBWDB); string .z.d)); 0 = count quote,1,,"Show that replayupd does not trigger savetables when quote is less than .wdb.maxrows[`quote]"
diff --git a/tests/wdb/timer/savetables_timer.csv b/tests/wdb/timer/savetables_timer.csv
@@ -0,0 +1,10 @@
+action,ms,bytes,lang,code,repeat,minver,comment
+before,0,0,q,update active:0b from `.timer.timer,,"Disable timer"
+before,0,0,q,.wdb.immediate:1b,,"Enable immediate write down"
+before,0,0,q,quotetmp:quote,,"Store quotes from tplog"
+before,0,0,q,".wdb.ignorelist,:`KUT`KUTR`quotetmp",,"Ignore `KUT`KUTR`quotetmp tables for save down"
+before,0,0,q,.wdb.savetodisk[],1,,"Write down all tables and clear in-memory"
+before,0,0,q,quote:([] time:2#.z.p; sym:`NVDA`TSLA; bid:148.75 299.10; ask:148.85 299.15; bsize:2000 1500; asize:500 750; mode:"ZZ"; ex:"LO"; src:`BARX`GETGO),,"Make small number of quotes for test"
+true,0,0,q,(counts < .wdb.maxrows `quote) and (0 < counts:count quote),1,,"Given quote table exists but row count is under threshold of .wdb.maxrows[`quote]"
+true,0,0,q,.wdb.savetodisk[]; 0 = count quote,1,,"Quote table therefore cleared using forcesave param and maxrows inequality disregarded"
+true,0,0,q,system " " sv (enlist "l"; "/" sv ((getenv `KDBWDB); string .z.d)); (count quote) > (count quotetmp),,"And data is successfully written to disk"
